Import name fix for NewYorkUniversity_Diabetes import#1962
Open
saanikaaa wants to merge 1 commit intodatacommonsorg:masterfrom
Open
Import name fix for NewYorkUniversity_Diabetes import#1962saanikaaa wants to merge 1 commit intodatacommonsorg:masterfrom
saanikaaa wants to merge 1 commit intodatacommonsorg:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the import_name in the manifest for New York diabetes data. A review comment correctly identifies that the proposed change to "NewYorkUniversity_Diabetes" misattributes the data source, which is the New York State Department of Health, and suggests using "NewYorkState_Diabetes" instead.
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is raised to fix the NewYorkUniversity_Diabetes auto-refresh job failing.
The import name in textproto file was different to the import name in the manifest JSON. This PR is raised to correct the manifest JSON import name to the textproto import name.
PR_CHECKLIST - https://docs.google.com/spreadsheets/d/1oZ2GOzVnf6qY9VNb2jMcKUdmz6E2qHHag6gCWA1H6oc/edit?gid=0#gid=0