Restore dyff rename detection option removed in PR #961#977
Closed
Restore dyff rename detection option removed in PR #961#977
Conversation
Agent-Logs-Url: https://github.com/databus23/helm-diff/sessions/79233bf7-466b-4356-8c9c-734f13b7c195 Co-authored-by: yxxhero <11087727+yxxhero@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix rename detection functionality in helm-diff
Restore dyff rename detection option removed in PR #961
Apr 17, 2026
Collaborator
|
@copilot add tests for this issue. |
Agent-Logs-Url: https://github.com/databus23/helm-diff/sessions/b7013dd7-5178-48fd-9249-ce54b121d833 Co-authored-by: yxxhero <11087727+yxxhero@users.noreply.github.com>
Contributor
Author
Added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #961 inadvertently removed the
dyff.DetectRenames(true)compare option fromprintDyffReport, breaking rename detection in dyff output format.dyff.DetectRenames(true)to the compare options indiff/report.goTestPrintDyffReportDetectsRenamestest to verify that dyff rename detection correctly correlates renamed resources and outputs field-level diffs instead of full document add/remove