Skip to content

fix: provide default mock for SPOG probe to avoid network calls in unit tests (closes #1274) #1502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
botbikamordehai2-sketch wants to merge 1 commit into from
Closed

fix: provide default mock for SPOG probe to avoid network calls in unit tests (closes #1274) #1502

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions tests/unit/spog/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@ def _guard_unmocked_requests_get():
AssertionError rather than letting it silently hit the network."""
with mock.patch(
"dbt.adapters.databricks.spog.probe.requests.get",
side_effect=AssertionError(
"Unmocked requests.get in a SPOG unit test. Patch "
"'dbt.adapters.databricks.spog.probe.requests.get' inside your test."
),
return_value=mock.Mock(status_code=200, text="ok"),
):
yield