Add additional test coverage for SSH connect command#5014
Open
Add additional test coverage for SSH connect command#5014
Conversation
Add unit tests for previously uncovered packages (keys, workspace, job submission, Run orchestrator) and expand client_test.go with FormatMetadata/IsServerlessMode/SessionIdentifier tests. Add local acceptance tests for cluster connect and validation flows. Add cloud acceptance test for serverless CPU. Extend testserver with jobs/submit and secrets/list handlers, and fix error_code in 404 responses for proper SDK error mapping. Co-authored-by: Isaac
anton-107
changed the title
Waiting for approvalBased on git history, these people are best suited to review:
Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
keys/package (14 tests),workspace/package (7 tests),Run()orchestrator (8 tests), andsubmitSSHTunnelJob(7 tests). Expandclient_test.gowithFormatMetadata,IsServerlessMode, andSessionIdentifiertable-driven tests.POST /api/2.2/jobs/runs/submitandGET /api/2.0/secrets/listhandlers. Fix 404 error responses to includeerror_code: "RESOURCE_DOES_NOT_EXIST"for proper SDK error mapping.connect-local-cluster(verifies API call sequence with mock server) andconnect-local-validation(tests 5 validation error cases).connect-serverless-cputest for serverless CPU compute (complements existing GPU test).Test plan
go test ./experimental/ssh/...— all 9 SSH packages pass (101 tests total)go test ./acceptance -run TestAccept/ssh/connect-local— both local acceptance tests passmake lint/make fmt/make checks— all cleanThis pull request was AI-assisted by Isaac.