acc: Make run_as/job_default test run only on direct#5012
Open
andrewnester wants to merge 2 commits intomainfrom
Open
acc: Make run_as/job_default test run only on direct#5012andrewnester wants to merge 2 commits intomainfrom
andrewnester wants to merge 2 commits intomainfrom
Conversation
Waiting for approvalCould not determine reviewers from git history. Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Make run_as/job_default test run only on direct
Why
This test on TF causes a permanent drift and differnce in the output. But for this test there is not real reason to run it on both direct and TF.
See the difference (
sourcefield is included) here:https://github.com/databricks-eng/eng-dev-ecosystem/actions/runs/24552546859/job/71781373042
Tests