sol: strip CBOR metadata from mock bytecode#676
Merged
Conversation
forge inspect emits the solc CBOR metadata section (ipfs hash of compiler metadata + solc version) appended to the bytecode. That metadata hash varies between forge versions even when solc itself is pinned, so 'go generate ./...' in CI produced .txt files that differ from whatever was committed locally. bytecode_hash = none + cbor_metadata = false tells solc to omit the metadata section entirely. The runtime bytecode is unchanged and the tests are unaffected (FVM precompile mocks don't depend on the metadata). Regenerated the three .txt files against the new config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`forge inspect` appends a CBOR metadata section to the deployedBytecode: an IPFS hash of the compiler metadata JSON plus the solc version tag. That IPFS hash drifts between forge versions even with `solc` pinned in `foundry.toml`. Locally (forge 1.5.1) it matches what was committed in #669; in CI (`foundry:latest`, newer) `go generate ./...` produces different trailing bytes and `git diff --exit-code` fails.
Fix: `bytecode_hash = "none"` + `cbor_metadata = false` -- solc omits the metadata section entirely. Output is deterministic across forge versions and solc patches. Regenerated the three .txt files against the new config; runtime bytecode is unchanged (FVM precompile mocks don't consult the metadata).
Currently blocks #670, #673, #674 after #675 unblocked the missing-`forge` issue.
Test plan