dealtracker: return result.Error, not shadowed outer err#671
Merged
Conversation
Two back-to-back blocks after the market-deal ingestion mark deals as expired / proposal-expired. Each checked result.Error but returned the outer-scope err, which at that point holds whatever the upstream streaming loop last set (nil on happy path). On a failed UPDATE the caller saw either a misleading 'success' or a stale error from an unrelated operation.
anjor
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
result.Error != nilchecks after the market-deal ingest loop were returning the outer-scopeerr(nil on happy path, or a stale error from upstream) instead ofresult.Error.UPDATE deals SET state=...the caller saw either misleading success or the wrong error.Test plan