Skip to content

[ffigen] Fix C++'s verify_bindings_test - #3564

Merged
dcharkes merged 1 commit into
mainfrom
ffigen_cpp_verify_test
Aug 18, 2026
Merged

[ffigen] Fix C++'s verify_bindings_test#3564
dcharkes merged 1 commit into
mainfrom
ffigen_cpp_verify_test

Conversation

@liamappelbe

Copy link
Copy Markdown
Contributor

Fixing a semantic merge conflict between #3542 and #3530 by migrating native_cpp_test/verify_bindings_test.dart to the new visitor API.

@github-actions

Copy link
Copy Markdown

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?

This check can be disabled by tagging the PR with skip-breaking-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer

Copy link
Copy Markdown
Contributor

There's also #3566.

@dcharkes
dcharkes merged commit 213a4e1 into main Aug 18, 2026
51 of 52 checks passed
@dcharkes
dcharkes deleted the ffigen_cpp_verify_test branch August 18, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants