Skip to content

Make sure users can fix permissions after onboarding#539

Merged
cooper (czxtm) merged 4 commits into
mainfrom
jp/permissions-check
Jul 17, 2026
Merged

Make sure users can fix permissions after onboarding#539
cooper (czxtm) merged 4 commits into
mainfrom
jp/permissions-check

Conversation

@arximboldi

Copy link
Copy Markdown
Contributor

Summary

With #501 the onboarding workflow is not shown anymore after completion (unless the user explictly requests it). However, the onboarding workflow was the only way users had an easy way to fix permissions if, for some reason, they got misconfigured again.

In this PR the permissions panel is added to the preferences window. Furthermore, the notification bubble that is displayed when the permissions are not matching anymore has a link to that panel, so users can quickly address the situation should it occur.

Test Plan

  • Manually test with the actual app as built from CI

Docs

  • Docs updated: added docs to test
  • No docs update needed

The permission list (status rows, grant/request actions, misplaced-bundle
warning) moves to components/widget/permissions/permissions-panel.tsx so it
can be reused outside the onboarding wizard. PermissionsStep keeps only the
onboarding chrome (StepShell, eyebrow, copy).
Settings gains a Permissions section rendering the shared PermissionsPanel,
so macOS permission status can be reviewed and the system grant flows
re-triggered after onboarding is complete. Adds the "permissions" variant
to SettingsTab and the widget story tab selector.
The revoked-permissions banner now opens the new settings tab instead of
deep-linking only the first missing permission, and keeps an explicit
"Check again" re-probe since repair is launch-scoped and won't observe
grants made while the app runs.
@darkmatter

darkmatter Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

🎨 Storybook preview

Open Storybook preview

Updated for 69a66c5


⚠️ Detected UI changes (5)

These stories' HTML snapshots changed. I've added screenshots + links to the changed stories below. Review them carefully then accept the changes to regenerate baselines and include them in this PR:

UI/InputGroup › Inline Addons

UI/InputGroup › Inline Addons

UI/InputGroup › Block Addons

UI/InputGroup › Block Addons

UI/Select › Provider

UI/Select › Provider

Flows/Evolve › Playground

Flows/Evolve › Playground

Flows/Evolve › 1. Begin (idle)

Flows/Evolve › 1. Begin (idle)


Accept UI changes

  • Click here to accept these changes

Alternatively, you can run bun run test:update-snapshots locally to re-generate the baselines and then push the changes to this PR.

What does this do?

The screenshots above show UI changes detected by the Storybook
snapshot tests run on this PR. Each image is the rendered output of
a Storybook story from the code in this PR branch; the snapshot
test compared it against the committed baseline in
__snapshots__/ and flagged the difference.

Checking the box tells the darkmatter[bot] to regenerate the
baselines from this PR's current code and commit them directly to
this branch. The new baselines become the source of truth for
future runs — only accept after confirming the visual changes are
intentional.

Comparison baseline: the committed __snapshots__/ files on this
PR branch (carried forward from develop). Accept updates them in
place on this branch.

@github-actions

Copy link
Copy Markdown
Contributor
Warnings
⚠️

No Linear issue ID found in this PR's title, description, or branch name (expected something like ENG-123). Add one so this work is traceable in Linear, or add #no-linear to the PR description to acknowledge it's intentionally untracked.

⚠️

New UI components were added without a Storybook story. Consider adding a sibling *.stories.tsx file:

  • apps/native/src/components/widget/permissions/permissions-panel.tsx
  • apps/native/src/components/widget/settings/permissions-tab.tsx

📋 PR Overview

Lines changed 627 (+384 / -243)
Files 3 added, 5 modified, 0 deleted
Draft / WIP no
Has Test Plan yes
Linear issue no
No Test Plan Needed no
New UI components yes (2)
New Storybook stories no
New Rust modules no
New TS source files yes (2)
New tests no
package.json touched no
Cargo.toml touched no
Infra / CI touched no

🔬 Coverage

Report Lines Statements Functions Branches
apps/native/coverage/coverage-summary.json 35.3% 34.8% 30.7% 29.6%

Generated by 🚫 dangerJS against 69a66c5

@czxtm
cooper (czxtm) added this pull request to the merge queue Jul 17, 2026
Merged via the queue into main with commit 4221292 Jul 17, 2026
10 checks passed
@czxtm
cooper (czxtm) deleted the jp/permissions-check branch July 17, 2026 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants