make error with progressivex_python.cpp.o

[whitecrow1027]

Hello, I got an error during make progressivex_python.cpp.o
error info:
make[2]: *** [CMakeFiles/pyprogressivex.dir/build.make:90: CMakeFiles/pyprogressivex.dir/src/pyprogressivex/src/progressivex_python.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:132: CMakeFiles/pyprogressivex.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
Could you help me to find what's wrong with it?

[whitecrow1027]

error info that may related:

/mnt/data1/code/refer_code/DeepLSD/third_party/progressive-x/graph-cut-ransac/src/pygcransac/include/estimators/../neighborhood/neighborhood_graph.h: At global scope:
/mnt/data1/code/refer_code/DeepLSD/third_party/progressive-x/graph-cut-ransac/src/pygcransac/include/estimators/../neighborhood/neighborhood_graph.h:91:23: �[01;31m�[Kerror: ‘unordered_map’ in namespace ‘std’ does not name a template type
91 | virtual const std::�[01;31m�[Kunordered_map<size_t, std::pair<std::vector<size_t>, std::vector<size_t>>>& getCells() const = 0;

/mnt/data1/code/refer_code/DeepLSD/third_party/progressive-x/graph-cut-ransac/src/pygcransac/include/GCRANSAC.h: In member function ‘void gcransac::GCRANSAC<_ModelEstimator, _NeighborhoodGraph, _ScoringFunction, _PreemptiveModelVerification, _FastInlierSelector>::labeling(const cv::Mat&, size_t, const std::vector<std::vectorcv::DMatch >&, gcransac::Model&, _ModelEstimator, double, double, std::vector&, double&)’:
/mnt/data1/code/refer_code/DeepLSD/third_party/progressive-x/graph-cut-ransac/src/pygcransac/include/GCRANSAC.h:909:10: �[01;31m�[Kerror: ‘clamp’ is not a member of ‘std’
909 | std::�[01;31m�[Kclamp(tmp_squared_distance / squared_truncated_threshold, 0.0, 1.0));

/mnt/data1/code/refer_code/DeepLSD/third_party/progressive-x/graph-cut-ransac/src/pygcransac/include/estimators/fundamental_estimator.h: In constructor ‘gcransac::estimator::FundamentalMatrixEstimator<_MinimalSolverEngine, NonMinimalSolverEngine>::FundamentalMatrixEstimator(double, bool, double)’:
/mnt/data1/code/refer_code/DeepLSD/third_party/progressive-x/graph-cut-ransac/src/pygcransac/include/estimators/fundamental_estimator.h:100:49: �[01;31m�[Kerror: ‘clamp’ is not a member of ‘std’
100 | minimum_inlier_ratio_in_validity_check(std::�[01;31m�[Kclamp(minimum_inlier_ratio_in_validity_check, 0.0, 1.0)),

In file included from /mnt/data1/code/refer_code/DeepLSD/third_party/progressive-x/graph-cut-ransac/src/pygcransac/include/types.h:42,
from /mnt/data1/code/refer_code/DeepLSD/third_party/progressive-x/graph-cut-ransac/src/pygcransac/include/utils.h:48,
from /mnt/data1/code/refer_code/DeepLSD/third_party/progressive-x/src/pyprogressivex/src/progressivex_python.cpp:4:
/mnt/data1/code/refer_code/DeepLSD/third_party/progressive-x/graph-cut-ransac/src/pygcransac/include/estimators/essential_estimator.h: In constructor ‘gcransac::estimator::EssentialMatrixEstimator<MinimalSolverEngine, NonMinimalSolverEngine>::EssentialMatrixEstimator(Eigen::Matrix3d, Eigen::Matrix3d, double, double)’:
/mnt/data1/code/refer_code/DeepLSD/third_party/progressive-x/graph-cut-ransac/src/pygcransac/include/estimators/essential_estimator.h:94:49: �[01;31m�[Kerror: ‘clamp’ is not a member of ‘std’
94 | minimum_inlier_ratio_in_validity_check(std::�[01;31m�[Kclamp(minimum_inlier_ratio_in_validity_check, 0.0, 1.0)),
| �[01;31m�[K^~~~~
/mnt/data1/code/refer_code/DeepLSD/third_party/progressive-x/graph-cut-ransac/src/pygcransac/include/estimators/essential_estimator.h:98:57: �[01;31m�[Kerror: ‘clamp’ is not a member of ‘std’
98 | point_ratio_for_selecting_from_multiple_models(std::�[01;31m�[Kclamp(point_ratio_for_selecting_from_multiple_models, 0.0, 1.0))

/mnt/data1/code/refer_code/DeepLSD/third_party/progressive-x/graph-cut-ransac/src/pygcransac/include/estimators/solver_p3p.h: In member function ‘size_t gcransac::estimator::solver::P3PSolver::solvePlaneRotation(const Vector3d*, const Vector3d&, const Vector3d&, double, double*, double*, double*) const’:
/mnt/data1/code/refer_code/DeepLSD/third_party/progressive-x/graph-cut-ransac/src/pygcransac/include/estimators/solver_p3p.h:182:26: �[01;31m�[Kerror: ‘clamp’ is not a member of ‘std’
182 | cos_theta[i] = std::�[01;31m�[Kclamp(roots[i], -1.0, 1.0);

/mnt/data1/code/refer_code/DeepLSD/third_party/progressive-x/graph-cut-ransac/src/pygcransac/include/estimators/perspective_n_point_estimator.h: In constructor ‘gcransac::estimator::PerspectiveNPointEstimator<_MinimalSolverEngine, NonMinimalSolverEngine>::PerspectiveNPointEstimator(double)’:
/mnt/data1/code/refer_code/DeepLSD/third_party/progressive-x/graph-cut-ransac/src/pygcransac/include/estimators/perspective_n_point_estimator.h:80:49: �[01;31m�[Kerror: ‘clamp’ is not a member of ‘std’
80 | minimum_inlier_ratio_in_validity_check(std::�[01;31m�[Kclamp(minimum_inlier_ratio_in_validity_check, 0.0, 1.0))

In file included from /mnt/data1/code/refer_code/DeepLSD/third_party/progressive-x/src/pyprogressivex/src/progressivex_python.cpp:12:
/mnt/data1/code/refer_code/DeepLSD/third_party/progressive-x/src/pyprogressivex/include/progx_utils.h: In function ‘double getMisclassificationError(const std::vector&, const std::vector&, int, int)’:
/mnt/data1/code/refer_code/DeepLSD/third_party/progressive-x/src/pyprogressivex/include/progx_utils.h:209:20: �[01;35m�[Kwarning: comparison of integer expressions of different signedness: ‘int’ and ‘std::vector::size_type’ {aka ‘long unsigned int’} [�[01;35m�[K-Wsign-compare]
209 | for (int i = 0; �[01;35m�[Ki < labeling.size(); ++i)

[whitecrow1027]

Full logs for cmake and make:
https://drive.google.com/file/d/18MlaDvsnWb_734C-ENi24Mci309EMBc6/view?usp=sharing
Thank you!

[jili233]

Hi! I have the same problem with you, could you please tell me how can we solve it? Thanks!

[whitecrow1027]

Hi! I have the same problem with you, could you please tell me how can we solve it? Thanks!

Sorry, I didn't solve it.

[jili233]

Hi! I successfully ran make, but haven't done any more testing. For errors related to clamp, I switched to this function given to me by GPT:
template<typename T> const T& clamp(const T& val, const T& minVal, const T& maxVal) { return (val < minVal) ? minVal : (val > maxVal) ? maxVal : val; }
And for unordered_map, I added:
#include <unordered_map>
Thanks for your reply and hope these could help you too.

[kd-scki3011]

Hello, I got an error during make progressivex_python.cpp.o error info: make[2]: *** [CMakeFiles/pyprogressivex.dir/build.make:90: CMakeFiles/pyprogressivex.dir/src/pyprogressivex/src/progressivex_python.cpp.o] Error 1 make[1]: *** [CMakeFiles/Makefile2:132: CMakeFiles/pyprogressivex.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs.... Could you help me to find what's wrong with it?

You can check your cmake version with "cmake --version" , at first, my cmake version is 3.26.0, then I change it to 3.24.3, and solve the problem