Skip to content

use thread parameter in local cluster - #1992

Merged
nfahlgren merged 3 commits into
v5.0from
respect-threading
Sep 2, 2026
Merged

nfahlgren merged 3 commits into
v5.0from
respect-threading

Conversation

@joshqsumner

@joshqsumner joshqsumner commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Describe your changes
Adds threads_per_worker argument to those taken by Client on a LocalCluster in parallel. This does not matter for most users but on Ubuntu keeps dask from using every core I have with multithreading when I run things locally.

Type of update
This is a bug fix

Associated issues
None.

Additional context
I'm not sure this matters for anyone else practically but it is a huge quality of life improvement for me and shouldn't cause anyone problems.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@joshqsumner joshqsumner added this to the PlantCV v5.0 milestone Aug 10, 2026
@joshqsumner joshqsumner added bug Bug or potential bug reports enhancement Enhancements to existing features labels Aug 10, 2026
@deepsource-io

deepsource-io Bot commented Aug 10, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 920645c...106e9ed on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Coverage  

Code Review Summary

Analyzer Status Updated (UTC) Details
Python Sep 2, 2026 9:44p.m. Review ↗
Code coverage Sep 2, 2026 9:44p.m. Review ↗

Code Coverage Summary

Language Line Coverage (New Code) Line Coverage (Overall)
Aggregate
100%
[✓ above threshold]
100%
Python
100%
[✓ above threshold]
100%

➟ Additional coverage metrics may have been reported. See full coverage report ↗


Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@annacasto
annacasto self-requested a review September 2, 2026 21:54
@annacasto annacasto removed their assignment Sep 2, 2026
@nfahlgren
nfahlgren merged commit 1ad9d0f into v5.0 Sep 2, 2026
5 checks passed
@nfahlgren
nfahlgren deleted the respect-threading branch September 2, 2026 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bug or potential bug reports enhancement Enhancements to existing features ready to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants