Skip to content

Lazy load spc - #1987

Merged
nfahlgren merged 3 commits into
v5.0from
lazy-load-spc
Aug 4, 2026
Merged

Lazy load spc#1987
nfahlgren merged 3 commits into
v5.0from
lazy-load-spc

Conversation

@joshqsumner

Copy link
Copy Markdown
Contributor

Describe your changes
Lazy load spectral (SPC) data in a PSII_data instance

Type of update
This is a feature update

Associated issues
Part of #1926

Additional context
Follows after #1986

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@joshqsumner joshqsumner added this to the PlantCV v5.0 milestone Jul 29, 2026
@joshqsumner joshqsumner added enhancement Enhancements to existing features merge in order Set of PRs that need to be merged sequentially labels Jul 29, 2026
@deepsource-io

deepsource-io Bot commented Jul 29, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 3310a32...2f6e681 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Coverage  

Code Review Summary

Analyzer Status Updated (UTC) Details
Python Aug 4, 2026 4:38p.m. Review ↗
Code coverage Aug 4, 2026 4:38p.m. Review ↗

Code Coverage Summary

Language Line Coverage (New Code) Line Coverage (Overall)
Aggregate
100%
[✓ above threshold]
100%
Python
100%
[✓ above threshold]
100%

➟ Additional coverage metrics may have been reported. See full coverage report ↗


Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@nfahlgren
nfahlgren merged commit 29a4cd2 into v5.0 Aug 4, 2026
5 checks passed
@nfahlgren
nfahlgren deleted the lazy-load-spc branch August 4, 2026 18:50
@joshqsumner joshqsumner mentioned this pull request Aug 7, 2026
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancements to existing features merge in order Set of PRs that need to be merged sequentially ready to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants