Faster roi filters - #1979
Open
joshqsumner wants to merge 10 commits into
Open
Conversation
 |
|
Overall Grade |
Security Reliability Complexity Hygiene Coverage |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Python |  |
Jul 24, 2026 4:56p.m. | Review ↗ |
| Code coverage | |
Jul 24, 2026 4:56p.m. | Review ↗ |
Code Coverage Summary
| Language | Line Coverage (New Code) | Line Coverage (Overall) |
|---|---|---|
| Aggregate | 100% [✓ above threshold] |
100% |
| Python | 100% [✓ above threshold] |
100% |
➟ Additional coverage metrics may have been reported. See full coverage report ↗
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
@marcusdgriff had an ai make new roi filtering functions as part of the gui project. After benchmarking they are faster in all but one (rare) context compared to our current methods. This PR replaces
roi.quick_filterwith those new internals and adds a "largest" option toroi.quick_filter(although "largest" may not always be faster in this framework).Type of update
This is a feature update.
Associated issues
None.
Additional context
Original code was from claude. In terms of review I've read it pretty thoroughly but it does use some
cv2that is new to me (and I assume others on the team) that could be good to familiarize with.For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md