feat: add ETag and full RFC 9110 conditional request support - #66
Open
kaiburjack wants to merge 1 commit into
Open
feat: add ETag and full RFC 9110 conditional request support#66kaiburjack wants to merge 1 commit into
kaiburjack wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since GCS computes ETags for all objects, we can add conditional HTTP requests support for ETag/If-None-Match and allow also potentially re-uploaded but identical (identical content hash, ETag) to be responded with 304 and cached by intermediary proxies/caches/CDNs.
Emit the GCS object etag as the ETag header on all object responses and evaluate the complete precondition set for this GET/HEAD proxy:
Preconditions run before Range processing and also cover default-index, walk-up, and SPA fallback responses (against the resolved object's etag); the -not-found 404 page is never conditional.
Gzip-stored objects get a weak W/"..." etag plus Vary: Accept-Encoding, since the same URL serves raw-gzip or GCS-transcoded bytes depending on the request's Accept-Encoding.
Also fixed: