revert: #506 bounds-check elimination (main CI red since merge)#511
Merged
revert: #506 bounds-check elimination (main CI red since merge)#511
Conversation
Contributor
Benchmark Results (Linux x86-64)
CLI Tool Benchmarks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main CI has been failing since #506 merged at 22:40 UTC. Stage1 self-hosting test
semantic/binary-type-in-functionfails becausecheckBinaryTypesDeepstops catching"hello" - 5inside function bodies when chad is self-hosted. Stage0 (node-driven) is unaffected.Local verification: building stage1 chad from this revert branch and running it directly against the fixture correctly emits
cannot use '-' between 'string' and 'number'and exits 1.Reverting to unblock all work on main. The perf work from #506 (bounds-check elimination) is a real improvement and should be re-applied, but it needs a proper self-hosting-safe implementation and a CI gate that waits for stage1 to finish before declaring green.
Followups needed (separate PRs)
Re-implement bounds-check elimination with full stage0→stage1→stage2 self-hosting verification before merge. The root cause of the miscompilation isn't yet understood — needs deeper investigation into why stage1 chad's
checkBinaryTypesDeepsilently drops its binary-op type check when compiled through perf: bounds-check elimination in loop-indexed array access #506's codegen path.Fix the pre-push auto-merge hook (
~/.claude/hooks/pre-push-rebase.sh). It currently evaluatesall_passedon the PR's statusCheckRollup at push time and triggers auto-merge if everything currently visible is green. GitHub populates the rollup incrementally as workflows start, so PRs with slowbuild-linux-glibc/build-macosjobs get merged after the fast checks (format-check, build, benchmarks) report success but before the slow ones have started. The hook should verify all expected jobs from the CI workflow file are COMPLETED before merging.Diff
8 files changed, 6 insertions(+), 557 deletions(-)