fix: suppress side-effect-free strict equality reports#3045
Open
ChargingFoxSec wants to merge 1 commit into
Open
fix: suppress side-effect-free strict equality reports#3045ChargingFoxSec wants to merge 1 commit into
ChargingFoxSec wants to merge 1 commit into
Conversation
c75f296 to
c002b11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3041.
This suppresses
incorrect-equalityfindings in side-effect-freeview/purefunctions, while preserving reports forview/purehelpers that are reachable from state-changing functions.Root cause
IncorrectStrictEquality.tainted_equality_nodescurrently skips top-level functions, but does not account for function mutability. As a result, strict equality checks in external/publicviewquery functions can be reported even when they do not gate a state transition.Changes
view/purefunctions when no non-view/purecaller can reach them.viewhelpers when they are reachable from a state-changing function.Testing
uv run pytest tests/e2e/detectors/test_detectors.py -k IncorrectStrictEqualityuv run ruff check slither/detectors/statements/incorrect_strict_equality.py tests/e2e/detectors/test_detectors.pyuv run ruff format --check slither/detectors/statements/incorrect_strict_equality.py tests/e2e/detectors/test_detectors.py