Add metrics for v2 hooks, add type to rejected/granted metrics#88
Merged
Conversation
In a similar fashion to what we have for v1, add some metrics about ADB v2 hooks status codes, so we can track if some v2 hooks do not answer as expected. Add the type of the NodeDisruption to disruption budget grant and reject metrics to help understand if rejections are specific to a type.
damsallem
approved these changes
Jun 10, 2026
| if err == nil { | ||
| return nil | ||
| } | ||
| if e, ok := err.(*openapiruntime.APIError); ok { |
Contributor
There was a problem hiding this comment.
Could we check that all svc.{any_method} do return only APIError to avoid logging "200" in metrics while it should be an error code ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a similar fashion to what we have for v1, add some metrics about ADB v2 hooks status codes, so we can track if some v2 hooks do not answer as expected.
Add the type of the NodeDisruption to disruption budget grant and reject metrics to help understand if rejections are specific to a type.