Add support to write logs to a file#87
Merged
Merged
Conversation
This will allow a sidecar to process the logs, either for indexing or any other usecase.
damsallem
requested changes
Jun 10, 2026
|
|
||
| w := &lumberjack.Logger{ | ||
| Filename: logPath, | ||
| MaxSize: 10, |
damsallem
approved these changes
Jun 10, 2026
matchaxnb
reviewed
Jun 10, 2026
matchaxnb
left a comment
matchaxnb
left a comment
There was a problem hiding this comment.
Cosmetic but we could call logOutput "makeLogOutput" as it produces an optional io.Writer and is not a function to log an output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow a sidecar to process the logs, either for indexing or any other usecase.
The chart will be updated in a follow-up commit / PR to support a custom sidecar.