fix: skip inherited keys when enumerating query operators - #277
Open
sheanming-agmo wants to merge 1 commit into
Open
sheanming-agmo wants to merge 1 commit into
sheanming-agmo wants to merge 1 commit into
Conversation
Query keys were enumerated with `for..in`, which walks the prototype
chain, so a polluted `Object.prototype` (e.g. `Object.prototype.$where`)
could inject operators into any query - even `sift({})` - and, via a
string `$where`, reach `new Function`. Guard both enumeration loops with
an own-property check.
Fixes CVE-2026-85625.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Author
|
is there someone who can merge this ? |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Query keys were enumerated with
for..in, which walks the prototype chain, so a pollutedObject.prototype(e.g.Object.prototype.$where) could inject operators into any query - evensift({})- and, via a string$where, reachnew Function. Guard both enumeration loops with an own-property check.Fixes CVE-2026-85625.