Skip to content

fix/ only show code actions related to project file if project file is present - #102

Merged
davidramnero merged 2 commits into
mainfrom
fix/only-show-code-actions-related-to-project-file-if-project-file-is-present
Aug 7, 2026
Merged

fix/ only show code actions related to project file if project file is present#102
davidramnero merged 2 commits into
mainfrom
fix/only-show-code-actions-related-to-project-file-if-project-file-is-present

Conversation

@davidramnero

Copy link
Copy Markdown
Collaborator

@davidramnero
davidramnero requested a review from danmar August 6, 2026 15:09
Comment thread src/util/codeActions.ts Outdated
/*
* Actions only applicable if project file is used
*/
if (!!this.projectFileStore.getUri()) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will the suppressions options be shown if --project=path/compile_commands.json is used? I have the feeling you should ensure the extension is ".cppcheck"

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it wouldn't happen because we didn't store the project file if it wasn't of this file type, but I agree this should be less of a hidden assumption, change inc

@davidramnero
davidramnero requested a review from danmar August 7, 2026 07:29
@davidramnero
davidramnero merged commit ed97238 into main Aug 7, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants