Skip to content

[Motions 2026 03 cwg 2] P4160R0 DR issues except <long list>#8922

Merged
tkoeppe merged 31 commits intomainfrom
motions-2026-03-cwg-2
Apr 12, 2026
Merged

[Motions 2026 03 cwg 2] P4160R0 DR issues except <long list>#8922
tkoeppe merged 31 commits intomainfrom
motions-2026-03-cwg-2

Conversation

@burblebee
Copy link
Copy Markdown
Contributor

@burblebee burblebee commented Apr 6, 2026

Fixes #8823.

Also fixes cplusplus/CWG#338
Also fixes cplusplus/CWG#545
Also fixes cplusplus/CWG#644
Also fixes cplusplus/CWG#656
Also fixes cplusplus/CWG#148
Also fixes cplusplus/CWG#673
Also fixes cplusplus/CWG#687
Also fixes cplusplus/CWG#706
Also fixes cplusplus/CWG#749
Also fixes cplusplus/CWG#813
Also fixes cplusplus/CWG#812
Also fixes cplusplus/CWG#801
Also fixes cplusplus/CWG#802
Also fixes cplusplus/CWG#800
Also fixes cplusplus/CWG#821
Also fixes cplusplus/CWG#826
Also fixes cplusplus/CWG#832
Also fixes cplusplus/CWG#837
Also fixes cplusplus/CWG#841
Also fixes cplusplus/CWG#838

Also fixes cplusplus/nbballot#606
Also fixes cplusplus/nbballot#605
Also fixes cplusplus/nbballot#604

Notes:

  • CWG2660: Not applied (already fixed by A. Jiang in 35904b9).
  • CWG2765: Targeted text in [expr.const] moved to [expr.const.core].
  • CWG2983: The 2nd sentence of [basic.pre]p7 is no longer present.

@eisenwave eisenwave added this to the post-2026-03 milestone Apr 6, 2026
@tkoeppe
Copy link
Copy Markdown
Contributor

tkoeppe commented Apr 6, 2026

Thanks a lot, @burblebee! Is this ready? (The PR is still in "draft" mode.)

@burblebee burblebee marked this pull request as ready for review April 7, 2026 10:23
@jensmaurer
Copy link
Copy Markdown
Member

CWG2660: Not applied (text rewritten by CWG2813).

While this is superficially true, the offending phase "this parameter of the function (7.5.3 [expr.prim.this]) is initialized with a pointer to the object of the call" still exists post-CWG2813. Please apply CWG2660 to that part.

@jensmaurer
Copy link
Copy Markdown
Member

I have added "fixes cplusplus/nbballot" links in the initial comment of this pull request. It would be good to amend the corresponding commits with our usual "Fixes NB ... (C++26 CD)." text (examples all over "git log").

@tkoeppe
Copy link
Copy Markdown
Contributor

tkoeppe commented Apr 7, 2026

There are 32 issues in Motion 2. Issue 3127 makes no changess.

@burblebee What about CWG2660?

@burblebee
Copy link
Copy Markdown
Contributor Author

CWG2660: Not applied (text rewritten by CWG2813).

While this is superficially true, the offending phase "this parameter of the function (7.5.3 [expr.prim.this]) is initialized with a pointer to the object of the call" still exists post-CWG2813. Please apply CWG2660 to that part.

Sorry, I referenced the wrong commit - the "this" pointer was fixed in by A. Jiang in 35904b9. I'll fix my note.

@tkoeppe
Copy link
Copy Markdown
Contributor

tkoeppe commented Apr 7, 2026

Ah, great, thanks!

@burblebee
Copy link
Copy Markdown
Contributor Author

burblebee commented Apr 7, 2026

I have added "fixes cplusplus/nbballot" links in the initial comment of this pull request. It would be good to amend the corresponding commits with our usual "Fixes NB ... (C++26 CD)." text (examples all over "git log").

Sorry, I totally missed those! The way they're formatted is too subtle; they look like part of the date. I seem to remember them being a lot more obvious.

I see - we now have a link where we used to have big, bold, black letters, right? The link is nice - thanks for doing that.

Can we do something to make the NB issues more obvious in the future? Maybe add a new, separate field for them, further away from the date? And, if possible, use a big bold font for the text of the link?

@jensmaurer
Copy link
Copy Markdown
Member

jensmaurer commented Apr 7, 2026

Sorry, I totally missed those! The way they're formatted is too subtle; they look like part of the date. I seem to remember them being a lot more obvious.

We used to have links in former times, too; I've used the existing XML machinery in the issues list (the deep links to the C++26 NB comments don't actually work). Compare these examples:

@burblebee burblebee force-pushed the motions-2026-03-cwg-2 branch 2 times, most recently from 325d3e8 to 3a5222d Compare April 7, 2026 12:50
@burblebee
Copy link
Copy Markdown
Contributor Author

Sorry, I totally missed those! The way they're formatted is too subtle; they look like part of the date. I seem to remember them being a lot more obvious.

We used to have links in former times, too; I've used the existing XML machinery in the issues list (the links to the C++26 don't actually work). Compare these examples:

Thanks for those references, I can see what made the NB issues more obvious - they were in the 1st column and separated from the usual fields by a newline.

@jensmaurer
Copy link
Copy Markdown
Member

jensmaurer commented Apr 7, 2026

I can see what made the NB issues more obvious - they were in the 1st column and separated from the usual fields by a newline.

Again, I fail to see a material visual difference between "this round" and "last round":

image
image

@tkoeppe
Copy link
Copy Markdown
Contributor

tkoeppe commented Apr 7, 2026

Thanks Dawn and Jens for sorting out the NB comment associations!

@burblebee
Copy link
Copy Markdown
Contributor Author

burblebee commented Apr 7, 2026

I can see what made the NB issues more obvious - they were in the 1st column and separated from the usual fields by a newline.

Again, I fail to see a material visual difference between "this round" and "last round":

The browser I'm using (Safari) shows something very different for "this round" - the NB comments appear directly left of the Date: entry. Whereas I do see what you see for "last round".

I'd embed an image of what I see but I don't know how you did that (neat!) - hopefully you can see what I mean from the following:

3058. "Program point" is not defined

Section: 6.5.1  [[basic.lookup.general](https://wg21.link/basic.lookup.general)]     Status: ready     Submitter: Alisdair Meredith     Date: 2025-08-13 [N5028 comment US 14-029](http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2025/n5028.pdf#US14-029)
(From submission [#749](https://github.com/cplusplus/CWG/issues/749).)

There is no definition for the term "program point".

For now, did I find them all? I only saw 2 issues with NB comments in this motion.

FYI - I tried in FireFox and Brave (a Chrome-like browser) and don't see those extra newlines that you see, so I guess it's a Mac issue?? Interesting... Just looked this up and apparently a known bug. Now that I know I'll try to remember to look in the future. Sorry to bother you!!!

@tkoeppe tkoeppe force-pushed the motions-2026-03-cwg-2 branch from 3a5222d to c114a77 Compare April 11, 2026 23:11
@tkoeppe tkoeppe force-pushed the motions-2026-03-cwg-2 branch from c114a77 to 5798c64 Compare April 11, 2026 23:26
@tkoeppe tkoeppe force-pushed the motions-2026-03-cwg-2 branch from 5798c64 to 30d255b Compare April 11, 2026 23:54
@tkoeppe tkoeppe merged commit e6a0efe into main Apr 12, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment