Skip to content

Respond to audit feedback#7

Merged
kaze-cow merged 7 commits into
mainfrom
audit-feedback
Jun 6, 2026
Merged

Respond to audit feedback#7
kaze-cow merged 7 commits into
mainfrom
audit-feedback

Conversation

@kaze-cow

@kaze-cow kaze-cow commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Description

Implement fixes from recent audit report.

Context

We recently completed an audit. Of the three informational issues identified, this PR includes changes for two of them:

Out of Scope

The audit report itself will be added to this repository once its finalized in a future PR.

Testing Instructions

[ ] Ensure the tests are still passing
[ ] Ensure the gas usage has not changed for the contract
[ ] Review the actual audit report response document/report itself, and confirm the responses are as expected.

kaze-cow added 2 commits June 4, 2026 14:43
prevents any possible compatibility issue with nonce invalidation
@kaze-cow kaze-cow self-assigned this Jun 4, 2026
@kaze-cow kaze-cow requested a review from a team June 4, 2026 06:08

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Solver7702Delegate contract to allow self-calls without value to bypass the authorization check, preventing them from reverting. Additionally, it refines the inline assembly comments in the fallback function to clarify memory overwrite behavior and introduces a new unit test to verify that self-calls succeed. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@fedgiac fedgiac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes by themselves look good.
Linting is failing and testing is failing. The former should be fixed, the latter seems to be unrelated but should be fixed somewhere.

Comment thread src/Solver7702Delegate.sol
@kaze-cow kaze-cow requested a review from fedgiac June 5, 2026 03:04
@kaze-cow kaze-cow merged commit d238229 into main Jun 6, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants