Drop the pool-indexer wait-until-timeout config#4561
Conversation
ec454b8 to
1d243f4
Compare
50f90f5 to
90b54b3
Compare
There was a problem hiding this comment.
Code Review
This pull request removes the configurable wait_until_timeout parameter from the Uniswap V3 pool indexer configuration. Instead, a hardcoded constant WAIT_UNTIL_TIMEOUT of 60 seconds is introduced in the pool indexer client, reflecting that bootstrapping now runs in a separate initContainer. Configuration parsing tests have been updated to ensure the obsolete field is rejected. No critical issues found.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
1d243f4 to
5bcf94d
Compare
90b54b3 to
92e9ee9
Compare
Description
wait-until-timeouton the pool-indexer liquidity config was sized (15m default) to cover a cold mainnet bootstrap back when bootstrap ran inside the serve container. Since the bootstrap-split (#4559) bootstrap runs as a separate initContainer, so the serve container is ready within seconds and the driver never waits on a cold bootstrap. The value was obsolete, and the long timeout was actively harmful as it hides a misconfigured or unreachable indexer for up to 15 mins (or hte configured timeout for that network), and the maintenance loop spends the full timeout each cycle waiting for a block the finalized-serving indexer never reaches.Changes
wait_until_timeoutfrom the driver's V3 pool-indexer config: the file config (IndexerConfig::PoolIndexer) and its default, the domain config (UniswapV3PoolIndexer), the config mapping, and the client constructor.