Skip to content

Drop the pool-indexer wait-until-timeout config#4561

Open
AryanGodara wants to merge 1 commit into
aryan/v3-on-demand-pool-fetchfrom
aryan/v3-drop-wait-until-timeout
Open

Drop the pool-indexer wait-until-timeout config#4561
AryanGodara wants to merge 1 commit into
aryan/v3-on-demand-pool-fetchfrom
aryan/v3-drop-wait-until-timeout

Conversation

@AryanGodara

Copy link
Copy Markdown
Member

Description

wait-until-timeout on the pool-indexer liquidity config was sized (15m default) to cover a cold mainnet bootstrap back when bootstrap ran inside the serve container. Since the bootstrap-split (#4559) bootstrap runs as a separate initContainer, so the serve container is ready within seconds and the driver never waits on a cold bootstrap. The value was obsolete, and the long timeout was actively harmful as it hides a misconfigured or unreachable indexer for up to 15 mins (or hte configured timeout for that network), and the maintenance loop spends the full timeout each cycle waiting for a block the finalized-serving indexer never reaches.

Changes

  • Removed wait_until_timeout from the driver's V3 pool-indexer config: the file config (IndexerConfig::PoolIndexer) and its default, the domain config (UniswapV3PoolIndexer), the config mapping, and the client constructor.

@AryanGodara AryanGodara self-assigned this Jun 24, 2026
@AryanGodara AryanGodara force-pushed the aryan/v3-on-demand-pool-fetch branch from ec454b8 to 1d243f4 Compare June 24, 2026 22:51
@AryanGodara AryanGodara force-pushed the aryan/v3-drop-wait-until-timeout branch from 50f90f5 to 90b54b3 Compare June 24, 2026 22:51
@AryanGodara AryanGodara marked this pull request as ready for review June 25, 2026 08:35
@AryanGodara AryanGodara requested a review from a team as a code owner June 25, 2026 08:35

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the configurable wait_until_timeout parameter from the Uniswap V3 pool indexer configuration. Instead, a hardcoded constant WAIT_UNTIL_TIMEOUT of 60 seconds is introduced in the pool indexer client, reflecting that bootstrapping now runs in a separate initContainer. Configuration parsing tests have been updated to ensure the obsolete field is rejected. No critical issues found.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@AryanGodara AryanGodara force-pushed the aryan/v3-on-demand-pool-fetch branch from 1d243f4 to 5bcf94d Compare June 25, 2026 09:09
@AryanGodara AryanGodara force-pushed the aryan/v3-drop-wait-until-timeout branch from 90b54b3 to 92e9ee9 Compare June 25, 2026 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant