ADD: Unit tests for MDEEStripHit - #185
Conversation
021e94f to
5a0416f
Compare
|
Tests for |
ckierans
left a comment
ckierans
left a comment
There was a problem hiding this comment.
I don't have enough unit test experience/knowledge to provide valuable feedback, but I gave the file a skim. If it's running through and working, then go for the merge!
| Passed = EvaluateFalse("MDEEStripHit()", "default trigger", "Default trigger flag is false", H.m_HasTriggered) && Passed; | ||
| Passed = EvaluateFalse("MDEEStripHit()", "default fast timing", "Default fast timing is false", H.m_HasFastTiming) && Passed; | ||
| Passed = Evaluate("MDEEStripHit()", "default TAC", "Default TAC value is 0", H.m_TAC, (unsigned int) 0) && Passed; | ||
| Passed = EvaluateNear("MDEEStripHit()", "default temperature", "Default temperature is 0", H.m_Temperature, 0.0, 1e-12) && Passed; |
There was a problem hiding this comment.
Not necessarily a comment for this PR, but I'm now seeing that you still have the m_Temperature variable in MDEEStripHit, but we removed it from MStripHit, so you might want another PR to clean that up.
There was a problem hiding this comment.
Good catch, I pushed another commit to remove this from both MDEEStripHit and MDEECrystalHit already in this (small) PR.
32e30ff to
45bcac4
Compare
45bcac4 to
bd44426
Compare
|
Looks good. You can merge when you're ready. |
2 participants
I used my left-over GitHub Copilot AI credits from July (before they expired) to create a unit-test file for
MDEEStripHit.