Trapping correction module and app - #184
Conversation
…e,h by fitted trapping parameters B,C
|
Can we also remove |
fhagemann
left a comment
fhagemann
left a comment
There was a problem hiding this comment.
Here is my feedback from just looking at the code.
I will also try to compile and run both the module and the app to provide more feedback on that as well! :)
There was a problem hiding this comment.
You added some cout lines to this: should this stay, or was this primarily for debugging and can be removed?
| Usage<<" --emin: minimum Event energy (default 30 keV)"<<endl; | ||
| Usage<<" --emax: maximum Event energy (default 5000 kev)"<<endl; |
There was a problem hiding this comment.
Later it looks like the defaults for --emin and --emax are actually 600 and 700keV, respectively. Can you cross-check all default values in this help message?
| // Read in the input files and make a list of hdf5 files to calibrate | ||
| if ((InputFile.GetSubString(InputFile.Length() - 4)) == "hdf5") { | ||
| HDFNames.push_back(InputFile); | ||
| cout << "hdf names loaded correctly" << endl; | ||
| } else if ((InputFile.GetSubString(InputFile.Length() - 3)) == "txt") { | ||
| cout << "Reading input file " << InputFile << endl; | ||
| cout << "WARNING: When passing a list of files, ensure that you have chosen the correct HDF5 continuous reading mode. Use the --nocontinue option to suppress continuous file reading." << endl; | ||
| MFile F; | ||
| if (F.Open(InputFile) == false) { | ||
| cout << "Error: Failed to open input file." << endl; | ||
| } else { |
There was a problem hiding this comment.
Are there examples for a txt input file?
There was a problem hiding this comment.
Do you have an example command to show how to run this app?
There was a problem hiding this comment.
If you run "TrappingCorrectionCs137 -h" it will tell you the app inputs to run it from the command line
| MString m_SimCCEFile; | ||
|
|
||
| // unordered_map<int, MDDetector*> m_Detectors; | ||
| vector<unsigned int> m_DetectorIDs; |
There was a problem hiding this comment.
What is this used for (other than checking if it is empty)? Can this also go?
| vector<unsigned int> m_DetectorIDs; |
There was a problem hiding this comment.
I think I want to hang on to the error message associated with this variable until I get a chance to test the module on data from multiple detectors at once. If it works well then I think it's okay to remove the error message on lines 134-139
There was a problem hiding this comment.
Then maybe add a // TODO comment prior to lines 134-139 so that we remember :)
|
The example file in 
|
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
3 participants
Contains a new module for applying depth-based charge trapping correction to individual hit energies along with modules with GUI options and GUI expos. The branch also includes an app for characterizing trapping with Cs-137 data. The trapping correction module requires a csv parameter file as input:
detector_0_trapping_parameters.csv
This file can also be found in resource/dee