[DEE] Update inverse depth calibration from pixel-based to strip-based - #158
[DEE] Update inverse depth calibration from pixel-based to strip-based#158fhagemann wants to merge 1 commit into
Conversation
|
Do we want to provide the option to provide a strip-based calibration or a pixel-based calibration? Or are we moving entirely to a strip-based calibration? |
|
I mean, the code exists for both, so we could also allow for either. |
|
So we'll need to make the same changes to the forward pipeline Depth Calibration module. |
|
My understanding was to keep the pixel-based calibration for the forward pipeline, but have the strip-based calibration for the DEE. Let's discuss this together with Field in tomorrow's meeting. |
|
I would postpone this PR to after having merged #165, as the latter might change where things are calculated/stored. |
|
Now that #165 is merged, I will look into updating this PR accordingly :) |
6cd1cfe to
a0f9f56
Compare
|
This PR is now rebased onto the latest commits on |
| ///////////////////////////////////////////////////////////////////////////////// | ||
|
|
||
|
|
||
| bool MModuleDepthCalibration::LoadStripCoeffsFile(MString FileName) |
There was a problem hiding this comment.
Up for debate:
I added the LoadStripCoeffsFile to read the strip-based depth coefficients file to MModuleDepthCalibration, even though it is never used in the forward pipeline.
The thought behind this was that both MSubModuleChargeTransport and MSubModuleDepthReadout require reading this file for z->drift time and timing smearing, respectively.
|
I'm marking this as "ready for review", but this will also require the generation of strip-based calibration files for all 16 flight detectors to be used with the COSI-SMEX-Payload mass model. |

Currently, we apply stretch and offset to the CTD/TAC values on a pixel by pixel basis.
Field looked into composing these stretches and offsets on a strip basis, and this PR provides the nuclearizer code to read it.
The file format currently looks like this (very preliminary, this might still change depending if we need more information):
I made some comparison to show that the pixel-based and strip-based files yield similar results (406-3 in STTC, illuminating with 241Am from the HV side):