Enable user-defined appstore sources - #299
Conversation
|
|
7d458a5 to
53c1930
Compare
|
is https://apps.ttmm.is/api up? |
|
I was hope that everything is fine. So it seems that Claude didn’t finished the project correctly. This need to wait 2 weeks. I just started holiday. If you can write me what is missing. Best,AlbertSent from my iPhoneOn 18 Jul 2026, at 22:59, Eric Migicovsky ***@***.***> wrote:ericmigi left a comment (coredevices/mobileapp#299)
is https://apps.ttmm.is/api up?
***@***.*** (view on web)
—Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Hi Eric,
Back from holiday — and with a proper answer to your question in the PR. The server is up, in full. You hit a 404 because the base is https://apps.ttmm.is/pebble, not /api — all routes live under /pebble/api/v1/, mirroring appstore-api.repebble.com.
Try these: apps.ttmm.is/pebble/api/v1/home/watchfaces (12 TIC watchfaces), /home/watchapps (TTMM Utilities), or a full card at /apps/id/c18cd584537b69cc926d53f0 — TTMM Alarms 1.1.0, released today, with descriptions, screenshots and changelog. The pbw installs from apps.ttmm.is/pebble/pbw/ttmm-alarms-v1.1.0.pbw.
The PR is unchanged since July: small diff, compiles, still needs an on-device pass — but now there's a live feed to test it against.
Thanks,
Albert
TTMM · ***@***.*** ***@***.***> · ttmm.is
… On 18 Jul 2026, at 22:59, Eric Migicovsky ***@***.***> wrote:
ericmigi
left a comment
(coredevices/mobileapp#299)
<#299 (comment)>
is https://apps.ttmm.is/api up?
***@***.*** (view on web) <https://github.com/user-attachments/assets/56b07ed0-a538-42db-93de-e7babdd3ca01>
—
Reply to this email directly, view it on GitHub <#299?email_source=notifications&email_token=CI75B4MMP4RFBLUDCV6UGWT5FPQLJA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMBRGI4TAMRRHA42M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-5012902189>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/CI75B4NLEQI6OLHVVZ4KO5T5FPQLJAVCNFSNUABFKJSXA33TNF2G64TZHM4TKOBZGI2DQMRZHNEXG43VMU5TIOJRGM2DKMZVGE2KC5QC>.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS <https://github.com/notifications/mobile/ios/CI75B4JDRKQGMPWB45BBOIL5FPQLJA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMBRGI4TAMRRHA42M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG> and Android <https://github.com/notifications/mobile/android/CI75B4OC2RAT57RILXMHHTL5FPQLJA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMBRGI4TAMRRHA42M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>. Download it today!
You are receiving this because you authored the thread.
|
|
tested PR verdict - Ul works, but 3 findings for review:
|
|
@ericmigi Thank you for the on-device pass — this is exactly the review the PR needed. All three findings were real, and fixing #2 uncovered a fourth. Status: 1. Sources wiped on relaunch — fixed, new commit in this PR. The initializer treated the whole sources table as builtin state: any row with 2. Store-home browse — fixed on the feed side, live now. 3. Deep link encoding — PR description updated. The One note for re-testing browse on a Time 2: the 12 TIC watchfaces intentionally ship no emery builds (no auto-scaled faces without the author's consent), so the watchfaces browse will be thin there — TTMM Alarms is emery-only and shows under Apps. A Core 2 Duo or any basalt/diorite watch shows the full watchfaces browse. |
The Add Source FAB and the per-source delete button were implemented but
commented out. The backing code (CreateAppstoreSourceDialog, addSource,
removeSource, AppstoreSourceDao) is already wired up, so this just enables
the UI.
Delete is offered only for user-added sources: removing a built-in feed
either strands the user (the Rebble source is never re-added by
AppstoreSourceInitializer) or trips its re-init path, which deletes and
recreates every source, silently dropping user-added ones.
Normalize the entered feed URL to the same canonical form as the built-in
feeds. It is string-concatenated into request URLs ("${source.url}/v1/...")
and compared for equality in addHeart()/isLoggedIn(), so a pasted trailing
slash or stray whitespace would otherwise produce a source that looks right
but silently fails to serve apps.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
pebble://appstore/{id} was hardcoded to the Rebble feed URL, so an app
card could only ever be opened from Rebble. handleAppstore() already takes
the feed URL as a parameter and resolves it against the enabled sources;
only the call site was fixed to Rebble.
Read the feed from an optional ?source= query parameter, falling back to
the Rebble feed when absent, so existing links keep working unchanged. A
source that is unknown or not enabled resolves to no store and hits the
existing "Failed to find app in enabled feeds" path.
Also replaces the inline Rebble URL with the existing REBBLE_FEED_URL
constant it duplicated.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
AppstoreSourceInitializer treated the whole sources table as builtin state: any row with algoliaAppId == null (which is every user-added source, since they have no Algolia credentials) re-triggered needsInit on the next launch, and init deleted ALL rows before reinserting the two builtins. Net effect: a source added via Add Source survived only until the app restarted, then silently disappeared. Scope the init/migration checks and the delete to the builtin feed URLs only, so user-added sources are left alone. First-run seeding and both migration paths (null Algolia fields, Pebble feed title change) behave as before for the builtin rows. Also replaces the inline repebble URL with the existing PEBBLE_FEED_URL constant it duplicated. Fixes the sources-wiped-on-relaunch behavior found in on-device review of coredevices#299. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
57e5d33 to
ff5c677
Compare
|
Fixed a few things, and added a new deep link to add a feed ( FYI @ttmm-sp-zoo trying to hide apps from Emery isn't supported right now. They are hidden from the collection, but a user can still install them on PT2 if they have them in the locker (and they can easily put them in the locker by connecting a different watch or overriding the watch type in the UI). Right now it looks confusing in the TTMM feed (when PT2 is connected all the faces show up on the home screen, but clicking on a collection will show blank). |
|
@sjp4 Thank you — for the review, the fixes, and especially On the Emery confusion — fair catch, and it was an inconsistency in our feed, not the app. Fixed and live now: Hiding the aplite–diorite faces from PT2 is intentional on my side: I don't want auto-scaled versions of these designs offered on the new screens — PT2-native TTMM faces are coming as their own collection. I'm aware the locker / watch-type-override path can still install them; that's fine, the flag expresses intent, not DRM. And I see it is already merged — thank you for landing it. |

Two small changes that unlock functionality already implemented in the app, so that third-party appstore feeds can be used end to end. No refactoring.
1. Enable the "Add Source" / "Delete Source" UI
AppstoreSettingsScreen.ktThe Add Source FAB and the per-source delete button were fully implemented but commented out.
CreateAppstoreSourceDialog,AppstoreSettingsScreenViewModel.addSource/removeSourceandAppstoreSourceDaoare already wired up, so this only uncomments the UI entry points.Delete is deliberately offered only for user-added sources, guarded with the existing
isPebbleFeed()/isRebbleFeed()helpers. Removing a built-in feed is unsafe today: deleting the Rebble source strands the user, asAppstoreSourceInitializernever re-adds it, while deleting the Pebble source trips that initializer's re-init path, which deletes and recreates every source and would silently drop user-added ones. Happy to drop this guard if you'd rather handle it differently.The entered URL is normalized (
trim().trimEnd('/')) to the same canonical form as the built-in feed constants. Until now everyAppstoreSource.urlcame fromINITIAL_APPSTORE_SOURCES, so it was canonical by construction; this dialog is the first path where the value is typed by a user. The URL is string-concatenated into request URLs ("${source.url}/v1/apps/id/$id") and equality-compared inaddHeart()/isLoggedIn(), so a pasted trailing slash would otherwise yield.../api//v1/apps/id/...and a source that looks correct but silently serves nothing.2. Let appstore deep links specify the feed to open from
PebbleDeepLinkHandler.kthandleAppstore()already takes the feed URL as a parameter and resolves it against the enabled sources — only the call site was fixed tohttps://appstore-api.rebble.io/api. As a result an app card could only ever be opened from Rebble.The feed is now read from an optional
?source=query parameter:The
?source=value must be URL-encoded (as above) — on iOS a raw, unencoded URL in the query does not survive URL parsing and the link will not navigate.?source=, the handler falls back to the Rebble feed exactly as before (the inline URL is replaced by theREBBLE_FEED_URLconstant it duplicated)."Failed to find app in enabled feeds"message. No new failure path.?source=matches the stored source URL exactly, so a link must use the same URL the source was added with — in the canonical, no-trailing-slash form the dialog now stores.Why
Third-party appstore feeds work today apart from this last mile. A working example is apps.ttmm.is — a store for TTMM watchfaces serving the full store API (per-platform descriptions, screenshots, collections). Browsing → installing a
.pbw→ loading the watchface config already works end to end on a physical device. What's missing is the ability to add the feed in the official app and to open an app card from it.This was agreed by email with Eric Migicovsky.
How to test
TTMM, URLhttps://apps.ttmm.is/pebble/api. Adding it with a trailing slash or surrounding whitespace should behave identically.pebble://appstore/{id}?source=https%3A%2F%2Fapps.ttmm.is%2Fpebble%2Fapifor an app id served by that feed — the card opens from that source instead of failing against Rebble. Install the.pbwfrom the card and confirm it loads on the watch.pebble://appstore/{id}with no?source=still opens the Rebble card while the Rebble source is enabled.?source=pointing at a disabled or unknown feed shows "Failed to find app in enabled feeds" and does not navigate.Testing status — please read
This has not been built or run. The change is written and reviewed statically, but no JDK or Android SDK was available in the environment used, so neither the Kotlin compile, the existing test suite, nor a device run were executed. It needs a real build and an on-device pass before merging.
No tests were added.
PebbleDeepLinkHandlerTestcurrently covers only the pureparseTokenFromhelper; exercisinghandleAppstorewould need fakes forLibPebble, analytics and the source DAO, and writing tests I cannot execute seemed worse than saying so plainly. Happy to add coverage if you want it in this PR.