Document Trivet owner account setup - #2
philipithomas wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9f76efb38f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Trivet does not have a separate application admin role or an admin-user | ||
| allowlist. A publisher becomes an owner by choosing **Sign up** on the Trivet | ||
| homepage and completing Google authentication. The OAuth callback creates (or | ||
| updates) an `Account` using the verified Google email address, and all signed-in |
There was a problem hiding this comment.
Don't claim owner emails are verified
This says the OAuth callback uses a verified Google email address, but the callback paths call verifyIdToken and then pass userInfo.email into handleOwnerSignIn; verifyIdToken only checks that an email field exists and never enforces email_verified. If Google returns an unverified email claim, the README overstates the owner-account guarantee and can mislead operators auditing how publisher accounts are created; either remove “verified” here or enforce the claim in the callback.
Useful? React with 👍 / 👎.
Summary
Validation
pnpm checkpnpm lintpnpm format:checkpnpm build