fix: update stale relation snapshots on entity re-fetch#21
Merged
Conversation
HasOne/HasMany handles previously skipped child snapshot updates when the entity already existed in the store, causing stale data after navigation (e.g. list → detail). Now compares embedded data against serverData and updates when changed. RelationStore.getOrCreateHasMany also updates serverIds when called with new values.
Remove duplicate function from HasOneHandle and HasManyListHandle, export single shared copy from BaseHandle.
…riting committed state After a persist (commit), re-rendering handles would read stale embedded data from the parent snapshot and overwrite the just-committed child state. Track the last propagated data reference per parent+field in SnapshotStore and only propagate when the reference changes (i.e. parent was re-fetched).
mapTempIdToPersistedId was not rekeying the propagation tracking map, causing hasEmbeddedDataChanged to return true after rekey and overwrite committed child state with stale embedded data from the parent snapshot.
…with same data Add embeddedDataMatchesSnapshot guard to HasOneHandle.ensureRelatedEntitySnapshot, matching the existing protection in HasManyListHandle. Without this, a parent re-fetch with unchanged server data (e.g. polling) creates a new object reference that passes the hasEmbeddedDataChanged check and overwrites unpersisted local mutations on the child entity. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
serverData(notdata, to preserve local mutations) and updates when changedRelationStore.getOrCreateHasManyalso updatesserverIdswhen called with new valuesembeddedDataMatchesSnapshottoBaseHandleto avoid duplicationTest plan
bun test)