Repository navigation
Conversation
send_notification() runs under the script-wide `set -euo pipefail`. The curl call to APPRISE_SIDECAR_URL was unguarded, so any failure to reach it (DNS, connection refused, timeout, ...) immediately terminated the whole script - aborting update processing for all remaining services, even though the notification is purely informational and has no bearing on whether updates should continue. Wrap the curl call in an `if` so a failed notification is logged and the run continues. Verified with a script sourcing send_notification() under `set -euo pipefail` against an unreachable URL: previously exited with code 7 before reaching the next statement, now logs the failure and continues.
moschlar
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What i changed
curlinsend_notification()against failuresWhy
The script runs with
set -euo pipefail, so an unreachableAPPRISE_SIDECAR_URLcaused the entire run to exit instantly. This could prevent updates for all
remaining services from being processed.
I tested with an unreachable notification URL under
set -euo pipefail:Before it exited with curl code 6.
Now it logs the failure and continiues
Cheers