Repository navigation
Bump sparql-benchmark-runner to 5.4.0 - #21
Merged
Merged
Conversation
5.4.0 writes raw results one by one, as WatDiv at scale 1000 exceeded the maximum string length when writing them all at once. It also waits until the CSV results are written, so they are no longer lost when the process exits right after. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UNM2PDyzVijfquXVY2Av52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WatDiv at scale 1000 crashed after all queries of a combination had finished, while writing its results:
Both
query-results-raw.jsonandquery-times.csvof that combination were lost, and the remaining combinations didn't run. sparql-benchmark-runner 5.4.0 (comunica/sparql-benchmark-runner.js#21) fixes this:query-times.csvis no longer lost when the process exits right after writing it.This updates the lockfiles of WatDiv and LDBC SNB, the two experiments that use sparql-benchmark-runner. Their experiment packages already accept
^5.3.0, so only the locked version changes. BSBM uses its own test driver, so it isn't affected.Checks
npm ciinstalls 5.4.0 in both experiments, andjbr validatepasses for both.Generated by Claude Code