fix: scrape course units from the units key without crashing - #116
Open
AshSgDe29071999 wants to merge 1 commit into
Open
fix: scrape course units from the units key without crashing#116AshSgDe29071999 wants to merge 1 commit into
AshSgDe29071999 wants to merge 1 commit into
Conversation
get_course_details returns "units", not "unit_value", so every course was stored as the default 6. int() also crashed on values like "3 units". Parse the first integer and default to 6 only when missing. Fixes compsci-adl#114
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`scraper.py` looked up `unit_value` while `get_course_details` emits `units`, so every course became 6. `int("3 units")` also crashed.
Changes
Test plan
Fixes #114