Fix frame sender: processModifierText reads wrong column - #1084
Open
minoseigenheer wants to merge 1 commit into
Open
minoseigenheer wants to merge 1 commit into
minoseigenheer wants to merge 1 commit into
Conversation
…lumn (9) Agent-Logs-Url: https://github.com/minoseigenheer/SavvyCAN/sessions/dbdf20c0-f636-46d6-9acd-d392b48126d4 Co-authored-by: minoseigenheer <34364368+minoseigenheer@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One-line bug fix in the frame sender window, targeting the QT6WIP branch.
Change (6734f4a)
processModifierText()was reading the text from column 8 (TRIGGER) instead of column 9 (MODS) due to a hardcoded magic number. This caused modifier expressions to always be empty, so data-byte modifiers in the send table had no effect.Fix: Replace the literal
8withST_COLS::SENDTAB_COL_MODS, the named constant that correctly identifies the modifiers column.Files changed
framesenderwindow.cpp