Skip to content

Additional context#736

Open
amkisko wants to merge 11 commits into
collectiveidea:mainfrom
amkisko:feature/additional-context
Open

Additional context#736
amkisko wants to merge 11 commits into
collectiveidea:mainfrom
amkisko:feature/additional-context

Conversation

@amkisko

@amkisko amkisko commented Oct 29, 2024

Copy link
Copy Markdown

Done:

  • updated README with additional instructions
  • implemented context storage and merging before audit record writing
  • implemented test coverage for changed parts
  • updated generators and templates

Background:

  • comment:string is not enough for storing and accessing additional context
  • known approach is to have separate column with additional serialized data
  • would be nice to avoid context storage on auditable record
  • would be nice to have global setter to add context once per request/job
  • should be always optional to add more context

References:

@amkisko

amkisko commented Nov 11, 2024

Copy link
Copy Markdown
Author

This one requires improvement, I completely missed the point that audited_changes is stored as text. context should be same for better support.

@amkisko

amkisko commented Nov 11, 2024

Copy link
Copy Markdown
Author

@danielmorrison fixes pushed here.

@amkisko

amkisko commented Dec 13, 2024

Copy link
Copy Markdown
Author

Same fixes applied here from #735

@amkisko

amkisko commented Nov 24, 2025

Copy link
Copy Markdown
Author

@danielmorrison Hey! Merge conflict resolved here too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant