Repository navigation
Enhance WindowsErrorPopupBlocker for run-time check failures. - #282
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in Cbc issues 792, some error popups still got through during the running of tests on Debug builds for Windows. This would block and eventually timeout Windows CI builds.
This PR enhances the WindowsErrorPopupBlocker by adding an additional hook for the CRT debug reporting system to print messages to stderr and abort.
To reproduce the issue fixed in this PR, build MSVC binaries in debug mode and use the following code snippet
Without this PR, such a debug build in MSVC of the above code would correctly result in a runtime exception
Run-Time Check Failure #2 - Stack around the variable 'i' was corrupted.because 'This caused the final "%lf" (8 bytes) to be written through the &i pointer (a 4-byte int on the stack), overflowing the stack frame.'. See also Commit b4e185d.