Repository navigation
Add Cbc quick tests for Windows MSVS CI - #839
Merged
Merged
Conversation
Use _sopen_s for safer temporary file creation in mipstart-test.cpp for compiler warning C4996 for unsafe CRT Library functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the "Quick test" suite, similar to
make test, for MSVS v17 and it'swindows-msvs-ci.Background
The legacy Cbc unit tests used in CI ('gamsTest, osiUnitTest, CInterfaceTest and friends') were replaced by quick tests, see also #806 and Commit
00c36f5.Thanks to PR #823, the MS VisualStudio v17 project files were updated, but the quick tests were not included for the
windows-msvs-cibuilds.Changes included
Add CbcMakeTest. Adds a single MSVS v17 project
CbcMakeTestthat builds one executable that calls each test in the "Quick test" suite, similar tomake testfor the other CI builds.UCRT64 instead of MINGW64. Change windows-msvs-ci to use msystem ucrt64 rather than mingw64, similar to windows-ci: install requirements into the MSYS2 used for the build #801.
Use the safe _sopen_s instead of _open. For MSVC-based builds, next: make
make testquick and move the sanity suite tomake sanity-test#806 added the use of_opento mipstart-test.cpp. However, this triggersWarning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS.. This implemented for MSVC (only) in mipstart-test.cpp.