Skip to content

refactor: extract CLI execution into cliExec module with improved UX#875

Open
EhabY wants to merge 3 commits intomainfrom
refactor/cli-exec-module
Open

refactor: extract CLI execution into cliExec module with improved UX#875
EhabY wants to merge 3 commits intomainfrom
refactor/cli-exec-module

Conversation

@EhabY
Copy link
Copy Markdown
Collaborator

@EhabY EhabY commented Apr 7, 2026

  • Split core/cliUtils into cliUtils (binary file management) and cliExec (command execution: version, speedtest, ping, openAppStatusTerminal)
  • Introduce CliEnv interface so callers don't manage shell escaping; each cliExec function resolves its own flags
  • Add resolveClientAndWorkspace for shared workspace resolution (sidebar, connected, or picker)
  • Use locateBinary (stat-only) in resolveCliEnv before falling back to fetchBinary
  • Surface CLI stderr in error messages instead of leaking full binary paths
  • Validate Go duration input in speed test prompt
  • Rename "Run Speed Test" → "Speed Test Workspace" in command palette, "Speed Test" in sidebar
  • Use separate :views command IDs for shorter context menu labels (GitLens pattern)
  • Remove "Diagnostics" submenu — inline commands directly in sidebar context menu

@EhabY EhabY changed the base branch from main to feat/ping-workspace April 7, 2026 14:13
@EhabY EhabY self-assigned this Apr 7, 2026
@EhabY EhabY force-pushed the feat/ping-workspace branch 2 times, most recently from ae6981a to 7b0ef6b Compare April 7, 2026 21:06
Base automatically changed from feat/ping-workspace to main April 7, 2026 21:14
@EhabY EhabY force-pushed the refactor/cli-exec-module branch from 00a3baa to 1897e73 Compare April 7, 2026 21:15
@EhabY EhabY force-pushed the refactor/cli-exec-module branch 2 times, most recently from 44f2a16 to 82d229d Compare April 8, 2026 09:24
@EhabY EhabY force-pushed the refactor/cli-exec-module branch from 82d229d to f297fe3 Compare April 8, 2026 09:48
@EhabY EhabY changed the title refactor: extract CLI command execution into core/cliExec module refactor: extract CLI execution into cliExec module with improved UX Apr 8, 2026
@EhabY EhabY requested a review from jeremyruppel April 8, 2026 15:32
Copy link
Copy Markdown

@jeremyruppel jeremyruppel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants