Conversation
…json files to include 'files' and 'publishConfig' fields for public access, and enhance README with logo
lguzzon
added a commit
to lguzzon-scratchbook/graph
that referenced
this pull request
Aug 14, 2026
, slice 1) Sequel to ADR-0001's Steps.ts split. Each mutation step now owns its AST-to-step conversion via a new static fromAST method instead of the logic living trapped in the astToSteps.ts central dispatcher. - SetStep/CreateStep/DeleteStep/RemoveStep/MergeStep in src/steps/mutation/ each implement static fromAST(clause); Delete/Remove are trivial, Set/ Create/Merge carry their conversion logic alongside the step. - New src/steps/shared/astToStepsHelpers.ts houses the shared normalizers (convertPropertyMap, convertNestedPropertyValue, convertSetValue, convertSetMapValue); SET/CREATE/MERGE import them; FOREACH's set-operation path reuses the single convertSetValue. - astToSteps.ts dispatches mutation clauses to the step's fromAST via a small name-to-constructor map; the 5 clause converters and 4 helpers are deleted from the dispatcher (3,346 to 3,059 lines). ASTConversionContext.queryContext made optional since mutation conversion is context-independent. - StepConstructor.fromAST broadened to accept any clause AST node. Suite stays green (5,563 pass, 0 fail). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
lguzzon
added a commit
to lguzzon-scratchbook/graph
that referenced
this pull request
Aug 14, 2026
…fromAST (Candidate codemix#2, slice 2) The four control clauses (WITH/UNWIND/CALL/FOREACH) all depend on the shared pattern+condition conversion engine (convertPattern / convertCondition / convertConditionValue, ~1,300 lines) that also serves fetch/traversal/filter steps and RETURN projections. Until it had a home, no non-mutation step could own its AST-to-step conversion. - New src/steps/shared/patternToSteps.ts: the pattern/condition engine moved verbatim out of astToSteps.ts and exported, so any step fromAST can reuse it. - astToSteps.ts: 3,059 -> 1,647 lines; dispatcher now imports the engine and keeps only clause-ordering/aliasing/RETURN concerns. - UnwindStep.fromAST implemented as the first control step to use the shared engine (convertConditionValue), proving the seam. - Pruned dead AST/Steps type and value imports left orphaned by both moves. Suite stays green (5,563 pass, 0 fail). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
lguzzon
added a commit
to lguzzon-scratchbook/graph
that referenced
this pull request
Aug 14, 2026
…lice 3) With the shared pattern/condition engine extracted in slice 2, the two remaining self-contained control clauses can now own their conversion: - ForeachStep.fromAST: converts the nested operations (SET -> SetStep, DELETE -> DeleteStep, MATCH -> convertPattern/convertShortestPathPattern) and the list expression, using the shared engine + mutation wrappers. - CallStep.fromAST: converts procedure arguments via convertConditionValue (shared) and yield items. - astToSteps.ts: 1,647 -> 1,502 lines; deletes convertForeachClause, convertListExpression, convertSetOperationToStep, convertCallClause and dispatches both clauses to the wrapper fromAST. Dead AST/Steps imports pruned. Suite stays green (5,563 pass, 0 fail). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.