Skip to content

service identification by identifier#320

Merged
raphael-goetz merged 2 commits intomainfrom
#307-service-identification-by-identifier
May 1, 2026
Merged

service identification by identifier#320
raphael-goetz merged 2 commits intomainfrom
#307-service-identification-by-identifier

Conversation

@raphael-goetz
Copy link
Copy Markdown
Member

Resolves: #307

@raphael-goetz raphael-goetz marked this pull request as ready for review May 1, 2026 17:01
Copilot AI review requested due to automatic review settings May 1, 2026 17:01
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 1, 2026

GitLab Pipeline Action

General information

Link to pipeline: https://gitlab.com/code0-tech/development/aquila/-/pipelines/2493945972

Status: Passed
Duration: 2 minutes

Job summaries

docs:preview

Documentation preview available at https://code0-tech.gitlab.io/-/development/telescopium/-/jobs/14179496093/artifacts/out/index.html

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses issue #307 by changing service authorization from token-only checks to token+identifier checks, aiming to ensure a service is uniquely identified by both its configured identifier and its token.

Changes:

  • Update server-side request handlers to validate requests using (token, identifier) rather than token alone.
  • Extend ServiceConfiguration with identifier-aware has_service/has_runtime/has_action checks plus runtime identifier normalization logic.
  • Add unit tests covering the new ServiceConfiguration matching rules.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/server/runtime_usage_service_server_impl.rs Switches runtime usage authorization to has_service(token, ...) (currently with a hard-coded identifier).
src/server/runtime_status_service_server_impl.rs Extracts runtime/action identifier from the status payload and authorizes via has_service(token, identifier).
src/server/module_service_server_impl.rs Authorizes module updates using an identifier taken from the module list.
src/server/action_transfer_service_server_impl.rs Tightens auth header validation and updates action authorization to use (token, identifier).
src/configuration/service.rs Introduces identifier-aware authorization helpers, identifier normalization, and adds tests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/server/runtime_usage_service_server_impl.rs
Comment thread src/server/module_service_server_impl.rs
Comment thread src/server/runtime_status_service_server_impl.rs
Comment thread src/configuration/service.rs
Comment thread src/configuration/service.rs
@raphael-goetz raphael-goetz merged commit d5d2c55 into main May 1, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A Service should be identified by identifier and token instead of just token

2 participants