service identification by identifier#320
Merged
raphael-goetz merged 2 commits intomainfrom May 1, 2026
Merged
Conversation
GitLab Pipeline ActionGeneral informationLink to pipeline: https://gitlab.com/code0-tech/development/aquila/-/pipelines/2493945972 Status: Passed Job summariesdocs:previewDocumentation preview available at https://code0-tech.gitlab.io/-/development/telescopium/-/jobs/14179496093/artifacts/out/index.html |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #307 by changing service authorization from token-only checks to token+identifier checks, aiming to ensure a service is uniquely identified by both its configured identifier and its token.
Changes:
- Update server-side request handlers to validate requests using
(token, identifier)rather than token alone. - Extend
ServiceConfigurationwith identifier-awarehas_service/has_runtime/has_actionchecks plus runtime identifier normalization logic. - Add unit tests covering the new
ServiceConfigurationmatching rules.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/server/runtime_usage_service_server_impl.rs |
Switches runtime usage authorization to has_service(token, ...) (currently with a hard-coded identifier). |
src/server/runtime_status_service_server_impl.rs |
Extracts runtime/action identifier from the status payload and authorizes via has_service(token, identifier). |
src/server/module_service_server_impl.rs |
Authorizes module updates using an identifier taken from the module list. |
src/server/action_transfer_service_server_impl.rs |
Tightens auth header validation and updates action authorization to use (token, identifier). |
src/configuration/service.rs |
Introduces identifier-aware authorization helpers, identifier normalization, and adds tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #307