Skip to content

Added PHP 8.5 support (composer + CI)#346

Merged
florianeckerstorfer merged 3 commits into
cocur:mainfrom
fulopattila122:main
Oct 10, 2025
Merged

Added PHP 8.5 support (composer + CI)#346
florianeckerstorfer merged 3 commits into
cocur:mainfrom
fulopattila122:main

Conversation

@fulopattila122

Copy link
Copy Markdown
Contributor

PHP 8.5 is already in RC phase, and is available for testing.

This PR adds PHP 8.5 to:

  • the composer.json file, to the allowed language versions, and
  • to the CI matrix

@florianeckerstorfer florianeckerstorfer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good

@fulopattila122

Copy link
Copy Markdown
Contributor Author

Looks like GitHub Actions is having difficulties with the older OS versions (macOS 13 and Ubuntu 20):

❌ action run cocur/slugify 18367953308

I've updated the CI def to latest fulopattila122@389ecc1 in my fork, and it just works fine:

✔️ action run fulopattila122/slugify 18400590280

Do you want me to:

  1. add that change to this PR, or
  2. add that change to a new PR, or
  3. do nothing with that?

Cheers

@florianeckerstorfer

Copy link
Copy Markdown
Member

Please add the change to this PR. Thank you

@fulopattila122

Copy link
Copy Markdown
Contributor Author

Please add the change to this PR. Thank you

☑️

@florianeckerstorfer florianeckerstorfer merged commit 04035c4 into cocur:main Oct 10, 2025
10 checks passed
@fulopattila122

Copy link
Copy Markdown
Contributor Author

Hi @florianeckerstorfer, PHP 8.5 is coming this week. Do you plan to release this package anytime soon?

Cheers

@fulopattila122

Copy link
Copy Markdown
Contributor Author

Hi @florianeckerstorfer - sorry for the pressure, could you please tag a release so that PHP 8.5 gets proper support?

We keep getting this in the CI for PHP 8.5:

image

@florianeckerstorfer

Copy link
Copy Markdown
Member

Hey, sorry, I created v4.7.0

@fulopattila122

Copy link
Copy Markdown
Contributor Author

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants