fix(loop-metrics): keep entries with unparseable run_id in timeframe filter - #499
Open
pxmpsdev wants to merge 3 commits into
Open
fix(loop-metrics): keep entries with unparseable run_id in timeframe filter#499pxmpsdev wants to merge 3 commits into
pxmpsdev wants to merge 3 commits into
Conversation
pxmpsdev
force-pushed
the
fix/loop-metrics-unparseable-run-id-filter
branch
from
August 10, 2026 09:19
16e56f1 to
df32673
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
filterEntries(used by--timeframe 7d) filters onnew Date(e.run_id). Whenrun_idis not an ISO timestamp — e.g. a numeric GitHub run id or a custom slug —new Date()returnsInvalid Date(it does not throw), so the comparisonNaN >= cutoffis alwaysfalseand the entry is silently dropped from every timeframe view. The existingtry/catchnever fires, andparseLogFileintentionally tolerates malformed lines — so the filter contradicts the parser's lenient behavior.Fix: Detect
Invalid DateviaNumber.isNaN(entryDate.getTime())and keep the entry, matching the conservative "keep what we can't parse" behavior.Verified: Added a regression test (numeric GitHub run id is kept with
--timeframe 30);cd tools/loop-metrics && npm testpasses (2 tests). Built dist is included.