Skip to content

fix(cli): reject dev --remote command - #278

Merged
ryanking13 merged 4 commits into
mainfrom
gyeongjae/remote-error
Oct 1, 2026
Merged

ryanking13 merged 4 commits into
mainfrom
gyeongjae/remote-error

Conversation

@ryanking13

@ryanking13 ryanking13 commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

We had a few cases where users were using pywrangler dev --remote and getting errors. This adds a clear error message that it is not supported and forwarding them to use remote bindings instead.

image

Comment thread packages/cli/src/pywrangler/unsupported_flags.py Outdated
@ask-bonk

ask-bonk Bot commented Sep 28, 2026

Copy link
Copy Markdown

I'm Bonk, and I've done a quick review of your PR.

Adds early rejection for pywrangler dev --remote.

  1. P1: Posted 1 inline suggestion.

github run

@dom96 dom96 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine, though I think it would make most sense to add this error message in wrangler (just in case someone runs wrangler instead of pywrangler)

@ryanking13

Copy link
Copy Markdown
Contributor Author

This seems fine, though I think it would make most sense to add this error message in wrangler (just in case someone runs wrangler instead of pywrangler)

Well wrangler still supports this feature. It currently warns users to user remote bindings instead, but probably they don't want to suddenly stop supprting this feature.

@dom96

dom96 commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

I mean add the error message just for Python Workers in Wrangler.

@ryanking13

Copy link
Copy Markdown
Contributor Author

Ah, I see. Yeah, probably. It is a little bit unclear which part should live in wrangler and which part should live in pywrangler though.

@ryanking13
ryanking13 merged commit a3d7508 into main Oct 1, 2026
18 of 19 checks passed
@ryanking13
ryanking13 deleted the gyeongjae/remote-error branch October 1, 2026 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants