Add support for per-phase user scripts#899
Open
mihaelabalutoiu wants to merge 6 commits into
Open
Conversation
Add the phase model and the extended UserScriptValue format Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
Centralize the uploaded/removed user-script state transition, recording a null removed entry when a target is cleared so it serializes to null. Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
`WizardScripts` now manages scripts through the per-target modal and a single `onScriptsChange` callback, applied across the flows via `applyUserScriptsChange`. Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
Polling refreshed `transfer.info` once an execution collected the VM `export_info` but never re-derived the instance details, so after executing a transfer those sections stayed empty until a manual page refresh. Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
mihaelabalutoiu
force-pushed
the
add-user-script-phases
branch
from
879c29a to
2a44c7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has the following changes:
applyUserScriptsChangestate helper;Choose Scriptsmodal;WizardScriptsnow manages scripts through the per-target modal and a singleonScriptsChangecallback, applied across the flows viaapplyUserScriptsChange.transfer.infoonce an execution collected the VMexport_infobut never re-derived the instance details, so after executing a transfer those sections stayed empty until a manual page refresh.