fix(alg): correct three shortest-path bugs - #161
Merged
Merged
Conversation
jsavyasachi
added a commit
that referenced
this pull request
Sep 26, 2026
docs(changelog): add shortest-path fixes for #161
NotAFlightRisk
pushed a commit
to NotAFlightRisk/loom
that referenced
this pull request
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes three bugs in the shortest-path family. Each has a regression test that fails on
master.bf-path: when start equals end, return[start]. It previously returnednil.johnson: the returned distances included the Bellman-Ford potentials used to remove negative weights. They are now the original path distances.astar-path: closed nodes are reopened when a shorter path is found, so paths stay optimal with an inconsistent heuristic.