Skip to content

ci(expo): combine unreleased clerk-ios bump changesets into one entry - #801

Merged
wobsoriano merged 1 commit into
mainfrom
rob/combine-pending-expo-bump-changesets
Nov 3, 2026
Merged

wobsoriano merged 1 commit into
mainfrom
rob/combine-pending-expo-bump-changesets

Conversation

@wobsoriano

@wobsoriano wobsoriano commented Nov 3, 2026 •

Copy link
Copy Markdown
Member

What & why

  • When clerk-ios ships more than once between clerk/javascript releases, this workflow writes one changeset per release. The @clerk/expo-native-components changelog then lists a bump line for each release (excerpt below), even though users only go from the version they had to the version they get.
  • The workflow now folds any unreleased expo-bump-clerk-ios-*.md changeset into the new one. The combined entry keeps the original "from" version and links every release in between. It deletes the old file and writes a new one, so the changelog credits the latest bump PR.

What to focus on

  • The node block in "Update Expo iOS SDK pin", which reads the "from" version and release links back out of the pending changeset text.

Testing

  • Ran this branch's "Update Expo iOS SDK pin" script against a clerk/javascript main checkout. With the two pending changesets on main and a 1.7.2 release, it wrote one entry from 1.6.2 to 1.7.2 with three release links and deleted both old files. A second run extended that combined entry. With nothing pending, the output matches today's. A rerun of an already pinned version still skips. actionlint passes.

Risk

  • Only changes the changeset files in the generated clerk/javascript PR. If a pending changeset can't be parsed, "from" falls back to the pinned version, as it does today.

How to revert

  • A plain revert is enough.

Screenshots / video

From the pending @clerk/expo-native-components@0.4.4 changelog in clerk/javascript#10571:

🤖 Generated with Claude under Rob's supervision.

@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Walkthrough

The workflow now combines pending Expo iOS SDK bump changesets into one replacement. It follows version transitions, collects and deduplicates release links, and uses singular or plural release wording based on the link count. It removes the matching pending changesets and stages the .changeset directory.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Suggested reviewers: mikepitre

Merge Risk: Minimal · up to 048eb

No actionable merge-blocking issue is established; the workflow appears ready for normal validation and the required code-owner approval.

Pre-merge checks: Passed 7
Check name Status Explanation
Title check Passed The title clearly states the main change: combining unreleased Clerk iOS bump changesets in the Expo workflow.
Description check Passed The description fills all required template sections and includes the rationale, review focus, testing details, risks, and rollback plan.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Testing, Risk, And Revert Passed The PR description includes all three required sections. Testing names the workflow script, pending changesets, output, deletion, rerun behavior, and actionlint. Risk explains the affected generated c…
Device Evidence Passed The pull request changes only .github/workflows/bump-javascript-expo-ios-sdk.yml. It does not change any file under Sources/ClerkKit/, Sources/ClerkKitUI/, or Examples/E2EHost/. Device evidenc…
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Testing, Risk, And Revert

Explanation

The PR description includes all three required sections. Testing names the workflow script, pending changesets, output, deletion, rerun behavior, and actionlint. Risk explains the affected generated changeset files and fallback behavior. How to revert states that a plain revert is sufficient.

Full details: Device Evidence

Explanation

The pull request changes only .github/workflows/bump-javascript-expo-ios-sdk.yml. It does not change any file under Sources/ClerkKit/, Sources/ClerkKitUI/, or Examples/E2EHost/. Device evidence is therefore not required.

Warning

Linked repositories: Some configured repositories could not be included in this review. Cross-repository analysis may be incomplete. Please check linked-repository access and settings.

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Automatic approval policy

Commit: 048ebbb665c1.

Setting Effective value Source
Automatic approvals Enabled Global configuration
Merge risk Moderate Global configuration
Security risk Not set Global configuration

Not set means no limit was configured after inheritance. Use @coderabbitai configuration to inspect the resolved settings and their sources.

Run configuration
Commits

Reviewing files that changed from the base of the PR and between 9f118b9 and 048ebbb.

Files selected for processing: 1
  • .github/workflows/bump-javascript-expo-ios-sdk.yml
Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

Included review availability: This review used your included allowance. 9 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.

@wobsoriano
wobsoriano marked this pull request as ready for review November 3, 2026 18:09
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

This pull request changes files listed in .github/protected-paths, so it needs an approval from another Team Mobile member before it can merge. CodeRabbit's approval isn't enough for these files.

  • .github/workflows/bump-javascript-expo-ios-sdk.yml

@wobsoriano
wobsoriano added this pull request to the merge queue Nov 3, 2026
Merged via the queue into main with commit d72fca3 Nov 3, 2026
28 of 30 checks passed
@wobsoriano
wobsoriano deleted the rob/combine-pending-expo-bump-changesets branch November 3, 2026 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants