Add rendering regression check - #160
Merged
Merged
Conversation
scripts/render-check.mjs generates a worker for a public Notion test page, runs it with wrangler dev and checks database views, images, PDF and file blocks, Mermaid, anchor links, database items and browser history in Chromium. Each check also runs against notion.site, and only failures that happen through Worknot alone are reported. The daily monitor workflow runs it and opens an issue on failure. Refresh the Notion baseline for client 23.13.20260925.1117, which the check passes. Closes #149 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
wrangler dev requires Node.js 22+. Exit code 2 now means the check could not run, which fails the job without opening a regression issue. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #149.
scripts/render-check.mjs(npm run check:render):src/code.ts(through Vite, so it runs on any supported Node version) and runs it withwrangler dev.NOTIONand doesn't fail the run, so Notion's own flakiness doesn't raise false alarms.render-checkjob on Node 24 (wrangler requires Node.js 22+). It opens or updates arender-regressionissue on exit code 1.baselines/notion-snapshot.jsonis refreshed for Notion client23.13.20260925.1117, released today. Only the version and app bundle name changed, and the render check passes with it.playwrightas a dev dependency (npm audit: 0 vulnerabilities).Verification
database rows and formulaisNOTION: since today's Notion client update, the table, gallery and list views show "No results" on notion.site itself too, and a worker built from the old master (fc1dacb) behaves the same.navigation and historyFAIL, and the script exits 1.workflow_dispatchon this branch: run 36169736563. Both jobs succeeded with the same results as locally.Notes
.nvmrcstill pins Node 20, which reached end of life in April 2026 and can no longer runwrangler dev/wrangler deploy(wrangler 4.131 requires Node.js 22+). Worth a separate update.