Skip to content

docs: mark separated-host RPC transport deprecated as of v0.8.0 - #295

Merged
ZhiyuCircle merged 1 commit into
circlefin:mainfrom
kutluhaneth46:docs/fix-separated-host-rpc-deprecation-294
Sep 10, 2026
Merged

docs: mark separated-host RPC transport deprecated as of v0.8.0#295
ZhiyuCircle merged 1 commit into
circlefin:mainfrom
kutluhaneth46:docs/fix-separated-host-rpc-deprecation-294

Conversation

@kutluhaneth46

Copy link
Copy Markdown
Contributor

Summary

Updates the separated-hosts warning in docs/running-an-arc-node.md: the RPC/HTTP Engine API transport is deprecated as of v0.8.0 (released), not will be deprecated.

Fixes #294

Test plan

  • Doc-only change; wording matches current release state
  • Removal timeline (v0.9.0) unchanged

@osr21

osr21 commented Aug 31, 2026

Copy link
Copy Markdown

Verified against main (66ad2d5): the diff applies to the current line 408 and the new wording keeps the v0.9.0 removal clause — the operationally important half for anyone running separated hosts today. Also confirmed the one-line scope is complete as-is: this was the only stale future-tense instance in the repo (line 789 of the same file already reads "HTTP/RPC transport (deprecated):"), and the admonition's remaining claims match the shipped v0.8.0 binary — crates/malachite-cli/src/cmd/start.rs emits the DEPRECATION: startup warning whenever an RPC transport option is set, with unit tests covering both polarities. Nothing else in the warning needs touching.

Two housekeeping notes:

@melekes

melekes commented Aug 31, 2026

Copy link
Copy Markdown

good catch 👍 thanks

@osr21

osr21 commented Aug 31, 2026

Copy link
Copy Markdown

@melekes Im available to offer contributions and support ahead of mainnet.

@kutluhaneth46

Copy link
Copy Markdown
Contributor Author

Friendly bump — @melekes you kindly flagged this as a good catch earlier. The one-line deprecation tense fix is still mergeable against current main and CI-green. Happy to rebase or close if the team wants this folded into a broader docs pass instead.

@kutluhaneth46

Copy link
Copy Markdown
Contributor Author

@ZhiyuCircle — one-line tense fix that’s still accurate on current main (will be deprecated in v0.8.0is deprecated as of v0.8.0). @melekes already called it a good catch. Happy to rebase if useful; otherwise this is ready for a quick maintainer look.

@ZhiyuCircle ZhiyuCircle added the pending-import Merged PR awaiting reverse-sync to upstream label Sep 9, 2026
@ZhiyuCircle

Copy link
Copy Markdown
Contributor

Can't merge, could you help to update signature for the commit ?

@kutluhaneth46
kutluhaneth46 force-pushed the docs/fix-separated-host-rpc-deprecation-294 branch from 75fdab2 to e075b96 Compare September 9, 2026 20:47
@kutluhaneth46

Copy link
Copy Markdown
Contributor Author

@ZhiyuCircle Rebased onto current main and re-signed the commit (SSH signature, author KutluhanETH <airdropzamani.resmi@gmail.com>). Please try merging again — happy to adjust further if GitHub still wants a different signing key on the account.

@kutluhaneth46
kutluhaneth46 force-pushed the docs/fix-separated-host-rpc-deprecation-294 branch from e075b96 to 9cc0fcd Compare September 9, 2026 20:48
@kutluhaneth46
kutluhaneth46 force-pushed the docs/fix-separated-host-rpc-deprecation-294 branch from 9cc0fcd to 291dda0 Compare September 9, 2026 21:09
@kutluhaneth46

Copy link
Copy Markdown
Contributor Author

@ZhiyuCircle Commit is now Verified (SSH signing key on my account). Should be ready to merge — thanks again.

@ZhiyuCircle
ZhiyuCircle merged commit b5e9db6 into circlefin:main Sep 10, 2026
18 checks passed
@circle-github-action-bot circle-github-action-bot added import-conflict Import failed 3-way merge; manual resolution required and removed pending-import Merged PR awaiting reverse-sync to upstream labels Sep 10, 2026
@kutluhaneth46

Copy link
Copy Markdown
Contributor Author

Thanks for the review and merge, @ZhiyuCircle — appreciated the patience on the verified-commit fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

import-conflict Import failed 3-way merge; manual resolution required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: separated-host warning still says RPC transport will be deprecated in v0.8.0

5 participants