Skip to content

fix: require admin credentials from env and block defaults in production - #59

Closed
kutluhaneth46 wants to merge 1 commit into
circlefin:masterfrom
kutluhaneth46:fix/require-admin-credentials-from-env
Closed

fix: require admin credentials from env and block defaults in production#59
kutluhaneth46 wants to merge 1 commit into
circlefin:masterfrom
kutluhaneth46:fix/require-admin-credentials-from-env

Conversation

@kutluhaneth46

Copy link
Copy Markdown

Summary

Require ADMIN_EMAIL and ADMIN_PASSWORD environment variables for first-run admin bootstrap — no hardcoded credentials in source.

  • Production refuses documented defaults (admin@admin.com, 123456, and other banned passwords).
  • auth-button.tsx uses ADMIN_EMAIL for admin detection (consistent with dashboard).
  • README and .env.example updated.

Fixes #47.

Test plan

  • Missing env vars → bootstrap skipped with warning (no user created)
  • NODE_ENV=production + default credentials → bootstrap refused
  • Custom credentials in .env.local → admin created on first run
  • Maintainer confirms SQL credits triggers note in README is acceptable for v1

@kutluhaneth46

Copy link
Copy Markdown
Author

Closing this to reduce open-PR noise and focus my remaining reviews on a smaller set of higher-signal threads.

Happy to reopen later if maintainers still want this change — thanks for your time.

1 similar comment
@kutluhaneth46

Copy link
Copy Markdown
Author

Closing this to reduce open-PR noise and focus my remaining reviews on a smaller set of higher-signal threads.

Happy to reopen later if maintainers still want this change — thanks for your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Security: Predictable default administrator credentials

1 participant