Repository navigation
[Buganizer ID: 545411510] Migrate Batch 10: ApacheKafka - #1425
Arabindaksha-Mishra wants to merge 5 commits into
Conversation
|
❌ Marketplace Validation Failed Click to view the full reportValidation Report
|
| Validation Name | Details |
|---|---|
| New integration project.toml and release_note.yaml version must be initialize to 1.0 | |
| 'apache_kafka' has connectors but doesn't have default mapping rules | |
| Apache Kafka is missing a 'Verify SSL' parameter |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request migrates the ApacheKafka integration to the open-source repository, adopting a modular structure to improve code organization and maintainability. The migration includes updated dependency management and a robust test suite to ensure functional parity with the previous implementation. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Signed-off-by: Arabindaksha Mishra <109797459+Arabindaksha-Mishra@users.noreply.github.com>
|
❌ Marketplace Validation Failed Click to view the full reportValidation Report
|
| Validation Name | Details |
|---|---|
| New integration project.toml and release_note.yaml version must be initialize to 1.0 | |
| 'apache_kafka' has connectors but doesn't have default mapping rules | |
| Apache Kafka is missing a 'Verify SSL' parameter |
1 similar comment
|
❌ Marketplace Validation Failed Click to view the full reportValidation Report
|
| Validation Name | Details |
|---|---|
| New integration project.toml and release_note.yaml version must be initialize to 1.0 | |
| 'apache_kafka' has connectors but doesn't have default mapping rules | |
| Apache Kafka is missing a 'Verify SSL' parameter |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new Apache Kafka integration, including ping actions, message connectors, and comprehensive unit tests. The review feedback identifies critical issues regarding consumer initialization to prevent data loss, adherence to path handling style guides, mandatory error message formatting for the Ping action, and minor type annotation typos.
|
❌ Marketplace Validation Failed Click to view the full reportValidation Report
|
| Validation Name | Details |
|---|---|
| New integration project.toml and release_note.yaml version must be initialize to 1.0 | |
| 'apache_kafka' has connectors but doesn't have default mapping rules | |
| Apache Kafka is missing a 'Verify SSL' parameter |
Signed-off-by: Arabindaksha Mishra <109797459+Arabindaksha-Mishra@users.noreply.github.com>
|
❌ Marketplace Validation Failed Click to view the full reportValidation Report
|
| Validation Name | Details |
|---|---|
| New integration project.toml and release_note.yaml version must be initialize to 1.0 | |
| 'apache_kafka' has connectors but doesn't have default mapping rules | |
| Apache Kafka is missing a 'Verify SSL' parameter |
1 similar comment
|
❌ Marketplace Validation Failed Click to view the full reportValidation Report
|
| Validation Name | Details |
|---|---|
| New integration project.toml and release_note.yaml version must be initialize to 1.0 | |
| 'apache_kafka' has connectors but doesn't have default mapping rules | |
| Apache Kafka is missing a 'Verify SSL' parameter |
|
❌ Marketplace Validation Failed Click to view the full reportValidation Report
|
| Validation Name | Details |
|---|---|
| New integration project.toml and release_note.yaml version must be initialize to 1.0 | |
| 'apache_kafka' has connectors but doesn't have default mapping rules | |
| Apache Kafka is missing a 'Verify SSL' parameter |
[Buganizer ID: 545411510] Migrate Batch 10: ApacheKafka
Description
Migrate the ApacheKafka integration from the legacy GoB repository (tip-marketplace) to the open GitHub repository (content-hub).
Deconstruction: Migrated source code into modular
actions/,connectors/,core/, andresources/structure with standardized relative imports for Chronicle SOAR packaging.Dependencies: Configured
pyproject.tomlanduv.lockwith required runtime and development dependencies (confluent-kafka==2.4.0,tipcommon,environmentcommon,soar-sdk,integration-testing, andpytest-mock).Tests: Configured test suite with
integration_testingfixtures inconftest.pyand verified all 55 unit tests acrosstests/test_defaults/,tests/test_actions/,tests/test_connectors/, andtests/test_manager.py.Validation: Verified with
mp check,mp validate,mp test, andmp build(100% AST and JSON definition parity againsttip-marketplace).