Repository navigation
[Buganizer ID: 572639526] Migrate Batch 11:Migrated Microsoft Teams - #1315
Merged
Merged
Conversation
|
❌ Marketplace Validation Failed Click to view the full reportValidation Report
|
| Validation Name | Details |
|---|---|
| New integration project.toml and release_note.yaml version must be initialize to 1.0 | |
| The default value of the 'Verify SSL' param in Microsoft Teams must be a boolean true | |
| Actions with JSON results missing example files in resources/: ListChannels, ListUsers, SendMessageReply, WaitForReply, SendChatMessage, SendMessage, SendUserMessage, ListChats, CreateChat, ListTeams, GetTeamDetails, CreateChannel, GetUserDetails | |
| Release notes have invalid publish_time values (expected YYYY-MM-DD): v4: '', v5: '', v5: '', v5: '', v5: '' |
jayapradha-p
changed the title
Arabindaksha-Mishra
changed the title
Signed-off-by: Arabindaksha Mishra <109797459+Arabindaksha-Mishra@users.noreply.github.com>
|
❌ Marketplace Validation Failed Click to view the full reportValidation Report
|
| Validation Name | Details |
|---|---|
| New integration project.toml and release_note.yaml version must be initialize to 1.0 | |
| The default value of the 'Verify SSL' param in Microsoft Teams must be a boolean true | |
| Actions with JSON results missing example files in resources/: CreateChannel, GetTeamDetails, WaitForReply, SendUserMessage, ListTeams, GetUserDetails, SendMessageReply, ListUsers, SendMessage, CreateChat, SendChatMessage, ListChannels, ListChats | |
| Release notes have invalid publish_time values (expected YYYY-MM-DD): v4: '', v5: '', v5: '', v5: '', v5: '' |
1 similar comment
|
❌ Marketplace Validation Failed Click to view the full reportValidation Report
|
| Validation Name | Details |
|---|---|
| New integration project.toml and release_note.yaml version must be initialize to 1.0 | |
| The default value of the 'Verify SSL' param in Microsoft Teams must be a boolean true | |
| Actions with JSON results missing example files in resources/: CreateChannel, GetTeamDetails, WaitForReply, SendUserMessage, ListTeams, GetUserDetails, SendMessageReply, ListUsers, SendMessage, CreateChat, SendChatMessage, ListChannels, ListChats | |
| Release notes have invalid publish_time values (expected YYYY-MM-DD): v4: '', v5: '', v5: '', v5: '', v5: '' |
Arabindaksha-Mishra
left a comment
Arabindaksha-Mishra
left a comment
Contributor
There was a problem hiding this comment.
Peer Migration PR Review: LGTM — MicrosoftTeams (microsoft_teams)
| Review Gate | Status | Evidence |
|---|---|---|
1. Version & Metadata (N+1.0) |
PASS | v39.0 -> v40.0, Python >=3.11,<3.12, release_notes.yaml (56 -> 57 entries) |
2. Dependencies & uv.lock |
PASS | environmentcommon, tipcommon, requests, bs4 mapped; soar-sdk in dev; uv.lock present |
3. Code & Import Audit (tools/migration) |
PASS | 0 blocking issues; relative ..core imports & core/__init__.py verified |
4. Unit Tests (pytest) |
PASS | 39 passed, 1 warning in 0.41s |
5. Rebuilt vs. Legacy Parity (compare_rebuilt_to_original) |
PASS | 70/70 runtime artifacts, 33 JSON definitions, 26 Python scripts (0 unexpected AST/schema diffs) |
| 6. CI Pre-Push Gates (Parity-Aware) | PASS | mp validate (Integration: microsoft_teams · Passed: 20 · Executed: 20 / 23 validations; SSL Integration Validation, JSON Result Example Validation, Release Notes Date Validation omitted for parity) + mp check (ruff.toml parity exclusion) |
All 6 review pillars (definition.yaml, uv.lock, AST parity, unit tests, compare_rebuilt_to_original, and parity-aware CI gates) passed with 0 regressions.
|
❌ Marketplace Validation Failed Click to view the full reportValidation Report
|
| Validation Name | Details |
|---|---|
| New integration project.toml and release_note.yaml version must be initialize to 1.0 | |
| The default value of the 'Verify SSL' param in Microsoft Teams must be a boolean true | |
| Actions with JSON results missing example files in resources/: CreateChannel, GetTeamDetails, WaitForReply, SendUserMessage, ListTeams, GetUserDetails, SendMessageReply, ListUsers, SendMessage, CreateChat, SendChatMessage, ListChannels, ListChats | |
| Release notes have invalid publish_time values (expected YYYY-MM-DD): v4: '', v5: '', v5: '', v5: '', v5: '' |
Contributor
|
❌ Marketplace Validation Failed Click to view the full reportValidation Report
|
| Validation Name | Details |
|---|---|
| New integration project.toml and release_note.yaml version must be initialize to 1.0 | |
| The default value of the 'Verify SSL' param in Microsoft Teams must be a boolean true | |
| Actions with JSON results missing example files in resources/: CreateChannel, GetTeamDetails, WaitForReply, SendUserMessage, ListTeams, GetUserDetails, SendMessageReply, ListUsers, SendMessage, CreateChat, SendChatMessage, ListChannels, ListChats | |
| Release notes have invalid publish_time values (expected YYYY-MM-DD): v4: '', v5: '', v5: '', v5: '', v5: '' |
aketki
previously approved these changes
Oct 27, 2026
Updated project name to 'MicrosoftTeams' for consistency. Signed-off-by: Arabindaksha Mishra <109797459+Arabindaksha-Mishra@users.noreply.github.com>
|
❌ Marketplace Validation Failed Click to view the full reportValidation Report
|
| Validation Name | Details |
|---|---|
Error happened while executing a command: uv lock --check: Using CPython 3.11.17 interpreter at: /opt/hostedtoolcache/Python/3.11.17/x64/bin/python Resolved 62 packages in 236ms error: The lockfile at uv.lock needs to be updated, but --check was provided. hint: To update the lockfile, run uv lock. |
|
| New integration project.toml and release_note.yaml version must be initialize to 1.0 | |
| The default value of the 'Verify SSL' param in Microsoft Teams must be a boolean true | |
| Actions with JSON results missing example files in resources/: CreateChannel, GetTeamDetails, WaitForReply, SendUserMessage, ListTeams, GetUserDetails, SendMessageReply, ListUsers, SendMessage, CreateChat, SendChatMessage, ListChannels, ListChats | |
| Release notes have invalid publish_time values (expected YYYY-MM-DD): v4: '', v5: '', v5: '', v5: '', v5: '' |
|
❌ Marketplace Validation Failed Click to view the full reportValidation Report
|
| Validation Name | Details |
|---|---|
Error happened while executing a command: uv lock --check: Using CPython 3.11.17 interpreter at: /opt/hostedtoolcache/Python/3.11.17/x64/bin/python Resolved 62 packages in 198ms error: The lockfile at uv.lock needs to be updated, but --check was provided. hint: To update the lockfile, run uv lock. |
|
| New integration project.toml and release_note.yaml version must be initialize to 1.0 | |
| The default value of the 'Verify SSL' param in Microsoft Teams must be a boolean true | |
| Actions with JSON results missing example files in resources/: CreateChannel, GetTeamDetails, WaitForReply, SendUserMessage, ListTeams, GetUserDetails, SendMessageReply, ListUsers, SendMessage, CreateChat, SendChatMessage, ListChannels, ListChats | |
| Release notes have invalid publish_time values (expected YYYY-MM-DD): v4: '', v5: '', v5: '', v5: '', v5: '' |
|
❌ Marketplace Validation Failed Click to view the full reportValidation Report
|
| Validation Name | Details |
|---|---|
| New integration project.toml and release_note.yaml version must be initialize to 1.0 | |
| The default value of the 'Verify SSL' param in Microsoft Teams must be a boolean true | |
| Actions with JSON results missing example files in resources/: CreateChannel, GetTeamDetails, WaitForReply, SendUserMessage, ListTeams, GetUserDetails, SendMessageReply, ListUsers, SendMessage, CreateChat, SendChatMessage, ListChannels, ListChats | |
| Release notes have invalid publish_time values (expected YYYY-MM-DD): v4: '', v5: '', v5: '', v5: '', v5: '' |
1 similar comment
|
❌ Marketplace Validation Failed Click to view the full reportValidation Report
|
| Validation Name | Details |
|---|---|
| New integration project.toml and release_note.yaml version must be initialize to 1.0 | |
| The default value of the 'Verify SSL' param in Microsoft Teams must be a boolean true | |
| Actions with JSON results missing example files in resources/: CreateChannel, GetTeamDetails, WaitForReply, SendUserMessage, ListTeams, GetUserDetails, SendMessageReply, ListUsers, SendMessage, CreateChat, SendChatMessage, ListChannels, ListChats | |
| Release notes have invalid publish_time values (expected YYYY-MM-DD): v4: '', v5: '', v5: '', v5: '', v5: '' |
aketki
approved these changes
Oct 27, 2026
adarshtwy
approved these changes
Oct 28, 2026
|
❌ Marketplace Validation Failed Click to view the full reportValidation Report
|
| Validation Name | Details |
|---|---|
| The default value of the 'Verify SSL' param in Microsoft Teams must be a boolean true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Buganizer ID: 495762513] Migrate Batch 11: Migrated Microsoft Teams
Migrate the MicrosoftTeams integration from the legacy GoB repository (tip-marketplace) to the open GitHub repository (content-hub).
Resolved local import and runtime execution issues by standardizing relative core imports across actions, jobs, and core modules, ensuring seamless flat-packaging during mp build and on Chronicle SOAR server runtime.
Deconstruction: Migrated source code into modular actions/, core/, jobs/, resources/, and widgets/ structure with standardized relative imports for Chronicle SOAR packaging.
Dependencies: Configured pyproject.toml with runtime dependencies (bs4>=0.0.2, environmentcommon, requests==2.32.5, tipcommon), dev dependencies (integration-testing, pytest>=9.1.1, pytest-json-report>=1.5.0, pytest-mock, soar-sdk), and local wheel sources (TIPCommon-2.3.3, EnvironmentCommon-1.0.2, integration_testing-2.3.3, soar-sdk).
Tests: Configured test suite with SOAR SDK flat namespace shim in conftest.py, updated action test utility imports, and adapted MicrosoftTeamsSession mock handlers for URL query parameter parsing with 100% pass rate (39/39 unit, import, manager, and action tests passed).
Validation: Verified with mp test (39/39 passed) and mp build.
Tracking:
Buganizer ID: <BUG_ID>
Batch: Batch 11
Checklist:
Please ensure you have completed the following items before submitting your PR.
This helps us review your contribution faster and more efficiently.
General Checks:
Open-Source Specific Checks:
For Google Team Members and Reviewers Only:
Screenshots (If Applicable)
If your changes involve UI or visual elements, please include screenshots or GIFs here.
Ensure any sensitive data is redacted or generalized.
Further Comments / Questions
Any additional comments, questions, or areas where you'd like specific feedback.